• go.work.sum: Language not supported

amqpjobs/redial.go:86

• [nitpick] There is an inconsistency in handling graceful close notifications: connection and consume channels use 'continue' while publish and statistic channels use 'return'. Please confirm if this behavior difference is intentional and consider adding inline comments to clarify the design.

if closed && err == nil { d.log.Debug("[notify close publish channel]: channel is closed")

amqpjobs/redial.go (4)

80-81: Incorrect log message for consume channel

The log message indicates the driver is stopped, but it should indicate that the redial channel is full (similar to other handlers).

-					d.log.Debug("[notify close consume channel]: channel is not closed, but driver is stopped")
+					d.log.Debug("[notify close consume channel]: redial channel is full (or redial in progress)")

---

118-119: Minor formatting issue in log message

There's an extra closing bracket at the end of the log message.

-					d.log.Debug("[notify close statistic channel]: channel is not closed, but driver is stopped]")
+					d.log.Debug("[notify close statistic channel]: channel is not closed, but driver is stopped")

---

130-131: Inconsistent log message for statistics channel

The statistic channel log message says "redialer stopped" while other handlers use "redial channel is full". For consistency, consider using the same message pattern.

-					d.log.Debug("[notify close statistic channel]: redialer stopped")
+					d.log.Debug("[notify close statistic channel]: redial channel is full (or redial in progress)")

---

34-132: Suggestion: Extract common patterns into helper methods

The four channel notification handlers follow very similar patterns with repeated code. Consider extracting this pattern into a helper method to improve maintainability and reduce duplication.

+ func (d *Driver) handleChannelClose(channelType string, err *amqp.Error, closed bool, notifySourceName string) bool {
+     // exit on a graceful close
+     if closed && err == nil {
+         d.log.Debug(fmt.Sprintf("[notify close %s channel]: channel is closed", notifySourceName))
+         return true // continue the loop
+     }
+ 
+     // stopped
+     if atomic.LoadUint64(&d.stopped) == 1 {
+         d.log.Debug(fmt.Sprintf("[notify close %s channel]: channel is not closed, but driver is stopped", notifySourceName))
+         return false // return to exit goroutine
+     }
+ 
+     select {
+     case d.redialCh <- &redialMsg{
+         t:   channelType,
+         err: err,
+     }:
+         d.log.Debug(fmt.Sprintf("[notify close %s channel]: redial message was sent", notifySourceName))
+         return false
+     default:
+         d.log.Debug(fmt.Sprintf("[notify close %s channel]: redial channel is full (or redial in progress)", notifySourceName))
+         return false
+     }
+ }

Usage would look like:

 case err, closed := <-d.notifyCloseConnCh:
-    // exit on a graceful close
-    if closed && err == nil {
-        d.log.Debug("[notify close connection channel]: channel is closed")
-        continue
-    }
-
-    // stopped
-    if atomic.LoadUint64(&d.stopped) == 1 {
-        d.log.Debug("[notify close connection channel]: channel is not closed, but driver is stopped")
-        return
-    }
-
-    select {
-    case d.redialCh <- &redialMsg{
-        t:   ConnCloseType,
-        err: err,
-    }:
-        d.log.Debug("[notify close connection channel]: redial message was sent")
-        return
-    default:
-        d.log.Debug("[notify close connection channel]: redial channel is full (or redial in progress)")
-        return
-    }
+    if d.handleChannelClose(ConnCloseType, err, closed, "connection") {
+        continue
+    }
+    return

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro