Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sberan
Copy link
Contributor

@sberan sberan commented Sep 9, 2025

Description

This flag allows dataset uploads to be sent as predictions (not automatically added to the dataset).

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this change been tested, please provide a testcase or example of how you tested the change?

Unit tests cover this case

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

@sberan sberan requested a review from iurisilvio September 9, 2025 20:09
@@ -287,6 +287,7 @@ def upload_dataset(
project_type: str = "object-detection",
batch_name=None,
num_retries=0,
are_predictions=False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to be consistent and keep using is_prediction.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally makes sense. I updated.

iurisilvio
iurisilvio previously approved these changes Sep 9, 2025
Copy link
Contributor

@iurisilvio iurisilvio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

You probably want to bump version before merge.

@sberan sberan merged commit 3b92a62 into main Sep 9, 2025
14 checks passed
@sberan sberan deleted the dataset-upload-are-predictions branch September 9, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants