Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Require --suite parent.suite to match the full suite name #4720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pekkaklarck opened this issue Apr 5, 2023 · 1 comment
Closed

Require --suite parent.suite to match the full suite name #4720

pekkaklarck opened this issue Apr 5, 2023 · 1 comment
Assignees
@pekkaklarck
Labels
alpha 1 backwards incompatible effort: small enhancement priority: medium
Milestone
v7.0

Comments

@pekkaklarck
Copy link
Member

When you use --test parent_name.test_name, there must be a test named test_name in a suite named parent_name and that suite must also be the root suite. On the other hand, --suite parent_name.suite_name works so that parent_name can also be a child suite. This is pretty inconsistent and needs to be changed.

The reason to requite --test parent_name.test_name to match the full suite name is that it makes it possible to explicitly pinpoint what test to run. If the name could match also partially, it could match also tests it shouldn't. For example Pabot relies on this functionality and it cannot be changed. If a partial match is needed, it's possible to use wildcards like --test *.parent_name.test_name.

I don't remember there being any reason why --suite parent_name.suite_name should also support partial matches. To make --test and --suite behavior consistent, it ought to thus be ok to change how --suite behaves. The change is backwards incompatible but we can do it in Robot Framework 7.0. I doubt this functionality is used so often that it should be deprecated first.
@pekkaklarck pekkaklarck added this to the v7.0 milestone Apr 5, 2023
@pekkaklarck
Copy link
Member Author

The exact behavior how --test and --suite isn't currently documented in the User Guide. I noticed that, and discovered this inconsistency, when I was writing about issues with the new Name setting (#4583) with the --suite option. I'll enhance documentation and also mention that the current behavior is subject to change.

The plan is to fix the aforementioned issue with --suite in RF 7.0 (#4688). It's good to make also other backwards incompatible --suite related changes in the same release.

@pekkaklarck pekkaklarck changed the title Requite --suite parent.suite to match the full suita name, starting from root Requite --suite parent.suite to match the full suite name Apr 5, 2023
@pekkaklarck pekkaklarck mentioned this issue Apr 5, 2023
Closed
pekkaklarck added a commit that referenced this issue Apr 5, 2023
@pekkaklarck
UG: Enhance --test and --suite documentation.
adf1a86 
- Explain their usage and how they work together better.
- Explain that new Name is not compatible with --suite (#4583)
- Explain how --suite is going to be changed (incl. fixing of the
  above issue) in RF 7.0 (#4720, #4721, #4688)
@pekkaklarck pekkaklarck self-assigned this Sep 11, 2023
@Snooz82 Snooz82 changed the title Requite --suite parent.suite to match the full suite name Require --suite parent.suite to match the full suite name Nov 9, 2023
@pekkaklarck pekkaklarck mentioned this issue Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pekkaklarck pekkaklarck

Labels
alpha 1 backwards incompatible effort: small enhancement priority: medium
Projects
None yet
Milestone
v7.0
Development

No branches or pull requests
1 participant
@pekkaklarck