issue #3317 resolved. Update required documentation #3414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR seems to lack tests altogether. They need to be added before it can be merged or even more thoroughly reviewed. Unfortunately this is too late for RF 3.2. |
|
Can you please tell me where I should add test cases. Either in test_importer_util.py or in test_imports.py |
|
Most importantly some acceptance tests are needed. |
miktuy
reviewed
Jan 23, 2020
| are automatically changed to backslashes (:codesc:`\\`) on Windows. | ||
| :file:`${RESOURCE_PATH}`). Additionally, forward slashes (`/` or `.`) in the path | ||
| are automatically changed to backslashes (:codesc:`\\`) on Windows. In case of | ||
| (`.`) last . is not going to replac. |
There was a problem hiding this comment.
mb you mean "...to replace"?
|
I close this PR because there has been no activity since 2019. The original issue #3317 is valid so I leave it open. Notice that implementing it probably wouldn't require changes in the code that was changed in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we will be able to add resources and file by using '.' as well as '/'.