Process: Support configuring log level keywords use #5204
Conversation
src/robot/libraries/Process.py
Outdated
| @@ -323,7 +323,7 @@ def __init__(self): | |||
| self._processes = ConnectionCache('No active process.') | |||
| self._results = {} | |||
|
|
|||
| def run_process(self, command, *arguments, **configuration): | |||
| def run_process(self, command, log_level=None, *arguments, **configuration): | |||
There was a problem hiding this comment.
log_level cannot be a positional argument because it would break pretty much all current usages of this keyword. It should be a keyword-only argument, but I'm not sure is it better to be a separate argument or should it be passed in in **configuration like other such options. The reason we've used **configuration instead of real keyword-only arguments is that this code was written originally for Python 2 that didn't even have keyword-only arguments. It probably should be refactored now, but that should be done separately from this PR. In the current situation including it in **configuration is probably easiest and most consistent.
There was a problem hiding this comment.
I am not sure, if it is properly done by just adding log_level through ProcessConfiguration __init__.
6cf8a40 to
1d2086f
Compare
|
tried run acceptance tests, all failed, rolling back this branch changes, and try to add the log_level arg into |
|
added atestsοΌ@pekkaklarck could you do a code review again, when you have time, no hurry, take your time, if any other important to do |
β¦g-log-level-keywords-use
β¦g-log-level-keywords-use
|
this interacts with this one #5302. It is likely that there will be some coordination necessary. |
sorry, I was in an long vacation, will try to merge these changes together |
|
Should be able to review again. when running locally one of the Unit test failed for some reason, but after pushing the change the unit tests passes all? |
|
I don't have time to review this now and I don't think there's enough time to get this into RF 7.3 either. I added the corresponding issue to RF 7.4 scope, though, so this shouldn't be forgotten. |
initial implementation, still need add
atestprobably toatest\testdataandatest\robot