Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Custom Test Settings a.k.a. Test Metadata #5281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

DanielSeim
Copy link

Hello Pekka,
here is the first PR regarding the ticket #4409 custom test settings a.k.a. test metadata.
Please have a look at it. Tests will follow soon for the metadata setting.
After that i will implement the custom settings: See also #4409 (comment) bullet points 5 and 6.

Best regards,
Daniel Seim

@pekkaklarck
Copy link
Member

pekkaklarck commented Nov 30, 2024

Thanks for the PR. In order to get RF 7.2 out still this year, we decided to move this functionality to RF 7.3 that we start developing right after the new year. Because I need to concentrate on 7.2, I won't have time to properly review this until it is in the release candidate phase. I took a quick look at the changes, though, and here are quick comments based on that:

  • In general changes look good.
  • The functionality to specify allowed metadata/setting names is missing. It is probably a good idea to implement it separately after the basic functionality is done, but it needs to be taken into account. It would be good to design it soon, but that can be discussion in the issue or on Slack.
  • Existing tests are broken and need to be fixed.
  • Plenty of new tests are needed. Parser changes can be tested using unit tests, but otherwise this is easiest to test on the acceptance tests level.
  • metadata should be after tags in TestCase.__init__ to avoid breaking usages where tags are passed as a positional argument. It needed to be at the end of the argument list to be even safer, but then the position would be too inconsistent.
  • XML and JSON schemas need to be updated.
  • Documentation is needed. We are going to recreate the User Guide as part of RF 7.3, so perhaps this should wait until that's done.

@LucianCrainic
Copy link
Contributor

Hello @DanielSeim is there a way i can help you out with this functionality ? Do you need a hand on anything regarding ?

@DanielSeim
Copy link
Author

FYI i will change the loading of the custom settings to cli options to get rid of the toml dependency as clarified at robocon.

@Noordsestern
Copy link
Member

The PR has merge conflicts that must be resolved before further evaluation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants