Support asking clarifying questions and allow user to follow up after investigation #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
arikalon1
previously approved these changes
May 6, 2025
There was a problem hiding this comment.
Thanks for the PR @lightme16
Great enhancement for Holmes!
Nice and clean
arikalon1
previously approved these changes
May 6, 2025
arikalon1
previously approved these changes
May 6, 2025
arikalon1
previously approved these changes
May 6, 2025
arikalon1
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make HolmesGPT more helpful, I added support for asking for clarifications. If a user asks, "Why did my deployment fail?" HolmesGPT will prompt them with, "What's the deployment name?" and "What’s the namespace?". Only after that it would start investigation.
Also, after the investigation wraps up, users can follow up on the report. They can ask more questions since that's often needed. You’ll want to keep iterating once HolmesGPT finds any problems.