[MRG] MAINT Reuse classes and functions to avoid code duplication #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amueller @GaelVaroquaux Are you okay with this approach? This will help avoid duplicated code (This is similar to my pr for avoiding duplicate code in model selection at scikit-learn#5568) |
There was a problem hiding this comment.
@amueller @GaelVaroquaux We need to subclass here to avoid sideeffects propagating to the original class LaplacianEigenmap (as deprecated modifies the __init__ of the passed class object)
1712fd8 to
8bd61fe
Compare
rohanp
added a commit
that referenced
this pull request
Nov 23, 2015
[MRG] MAINT Reuse classes and functions to avoid code duplication
|
I don't understand what's happening here. This is a move of spectral embedding to laplacian eigenmaps, right? Why is this not a PR to scikit-learn? |
|
Instead of duplicating the code, I sent a PR to his branch to reuse the functions and classes... The main PR is over here - scikit-learn/pull/5883 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rohanp Please review and merge. This commit avoids duplication in code...