-
-
Notifications
You must be signed in to change notification settings - Fork 600
Update plugins to be built with TypeScript 4 #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm going to update the For the sake of expediency for this effort, I'd say tackle one at a time, and add the updated typescript dependency to each plugin being worked on. (We can do a follow up commit later to remove this deps if needs be). I do also want to raise awareness in this issue that we have a lot of plugins that we haven't been able to get around to converting to TS, and that's likely more important than updating the TS version, but it's hard to say for certain because one could argue that it'd be easier to do on an updated version of TS. |
The individual plugins are using TypeScript 4 now. Should we remove the TypeScript version from the base |
I'd update the base. It'll be a while before we have to do another major version bump of that. |
With all of the PRs for this update merged, we should be good to close this. |
Uh oh!
There was an error while loading. Please reload this page.
master
Expected Behavior / Situation
I would like the plugins to be built with TypeScript 4 so that we are using the latest version
Actual Behavior / Situation
package.json
contains"typescript": "^3.9.7",
Modification Proposal
Update
package.json
to"typescript": "^4.0.0",
. Here's a commit showing the other required changes: 8d07a42What is the process for this? Do we need to update one plugin at a time?
The text was updated successfully, but these errors were encountered: