Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update plugins to be built with TypeScript 4 #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benmccann opened this issue Dec 2, 2020 · 4 comments
Closed

Update plugins to be built with TypeScript 4 #679

benmccann opened this issue Dec 2, 2020 · 4 comments

Comments

@benmccann
Copy link
Contributor

benmccann commented Dec 2, 2020

  • Rollup Plugin Name: various
  • Rollup Plugin Version: master

Expected Behavior / Situation

I would like the plugins to be built with TypeScript 4 so that we are using the latest version

Actual Behavior / Situation

package.json contains "typescript": "^3.9.7",

Modification Proposal

Update package.json to "typescript": "^4.0.0",. Here's a commit showing the other required changes: 8d07a42

What is the process for this? Do we need to update one plugin at a time?

@shellscape
Copy link
Collaborator

I'm going to update the CONTRIBUTING doc to cover this question. Updating multiple plugins at once isn't something we'd like to encourage; mostly because it requires a super clean commit history in the feature branch, but also because multiple plugin updates are harder for contributors to review, and we've got a lot of folks that only tend to one or two plugins here. To make matters more murky, it looks like the typescript dependency is at the root, so that makes things nice and uniform but also tricky.

For the sake of expediency for this effort, I'd say tackle one at a time, and add the updated typescript dependency to each plugin being worked on. (We can do a follow up commit later to remove this deps if needs be). I do also want to raise awareness in this issue that we have a lot of plugins that we haven't been able to get around to converting to TS, and that's likely more important than updating the TS version, but it's hard to say for certain because one could argue that it'd be easier to do on an updated version of TS.

@benmccann
Copy link
Contributor Author

The individual plugins are using TypeScript 4 now. Should we remove the TypeScript version from the base package.json or should we set the base version to version 4 and remove the version from the sub-packages?

@shellscape
Copy link
Collaborator

I'd update the base. It'll be a while before we have to do another major version bump of that.

@shellscape
Copy link
Collaborator

With all of the PRs for this update merged, we should be good to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants