Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test(typescript): test added for issue #735 #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

test(typescript): test added for issue #735 #736

wants to merge 3 commits into from

Conversation

Samantha-uk
Copy link

Rollup Plugin Name: plugin-typescript

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: #735

Description

This is a test that illustrates #735.
It is currently set to .skip (as at present it fails)

@benmccann
Copy link
Contributor

Does this test pass if you set the TypeScript version to 4.2.0-dev.20210101?

@Samantha-uk
Copy link
Author

4.2.0-dev.20210101

After updating the package.json for the typescript plugin to "typescript": "4.2.0-dev.20210101" this test still fails (with the same error being reported) 😞

@shellscape shellscape changed the title test(typescript) test added for issue #735 test(typescript): test added for issue #735 Feb 4, 2021
@Samantha-uk Samantha-uk requested a review from shellscape as a code owner July 15, 2021 19:24
@shellscape shellscape force-pushed the master branch 11 times, most recently from c33e948 to 1ae22f4 Compare July 15, 2021 21:28
@shellscape
Copy link
Collaborator

I think we can safely close this one now. Thanks for everyone's efforts.

@shellscape shellscape closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants