Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Slightly improve perf report #5501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 30, 2024
Merged

Slightly improve perf report #5501

merged 5 commits into from
Apr 30, 2024

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This improves some minor things about the perf report

  • make it work for forks if a tag is set, or do not run it for forks for security reasons
  • use a nested list for better readability
  • try to make the numbers a little more stable

@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 8:06pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#refine-perf-report

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-bcgnhk6xm-rollup-js.vercel.app/repl/?pr=5501

@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.81%. Comparing base (dbf0a2e) to head (fa286d2).

Files Patch % Lines
src/utils/timers.ts 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5501   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         238      238           
  Lines        9538     9538           
  Branches     2436     2436           
=======================================
  Hits         9425     9425           
  Misses         48       48           
  Partials       65       65

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit f39b24f into master Apr 30, 2024
@lukastaegert lukastaegert deleted the refine-perf-report branch April 30, 2024 04:12
@github-actions GitHub Actions
Copy link

This PR has been released as part of [email protected]. You can test it via npm install rollup.

This was referenced May 21, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request May 22, 2024
Open
This was referenced May 23, 2024
Open
Open
Open
Open
Open
Open
Open
@YashGovekar YashGovekar mentioned this pull request May 30, 2024
Open
@x-way x-way mentioned this pull request May 31, 2024
Closed
This was referenced Jun 1, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 4, 2024
Open
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 8, 2024
Open
This was referenced Sep 9, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 17, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 23, 2024
Open
Open
Open
This was referenced Sep 25, 2024
Open
Open
Open
Open
Open
Open
Open
@YashGovekar YashGovekar mentioned this pull request Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukastaegert