Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

I discovered that most of the enums implement a Spanned trait that provides derived positions for the SWC AST enums. Using this, we can simplify the logic in some places.

Copy link

vercel bot commented May 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2024 8:16am

Copy link

github-actions bot commented May 26, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#use-built-in-spans

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-3e2a0vtmx-rollup-js.vercel.app/repl/?pr=5529

Copy link

github-actions bot commented May 26, 2024

Performance report!

Rough benchmark

Command Mean [s] Min [s] Max [s] Relative
node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js 9.147 ± 0.040 9.120 9.193 1.00
node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js 9.156 ± 0.044 9.109 9.197 1.00 ± 0.01

Internal benchmark

  • BUILD: 8315ms, 752 MB
    • initialize: 0ms, 26.1 MB
    • generate module graph: 3188ms, 575 MB
      • generate ast: 1554ms (+35ms, +2.3%), 567 MB
    • sort and bind modules: 459ms, 614 MB
    • mark included statements: 4682ms, 752 MB
      • treeshaking pass 1: 1573ms, 718 MB
      • treeshaking pass 2: 759ms, 736 MB
      • treeshaking pass 3: 302ms, 749 MB
      • treeshaking pass 4: 280ms, 744 MB
      • treeshaking pass 5: 327ms, 750 MB
      • treeshaking pass 6: 269ms, 747 MB
      • treeshaking pass 7: 250ms, 749 MB
      • treeshaking pass 8: 242ms, 748 MB
      • treeshaking pass 9: 222ms, 758 MB
      • treeshaking pass 10: 224ms, 756 MB
      • treeshaking pass 11: 222ms, 752 MB
  • GENERATE: 888ms, 1.02 GB
    • initialize render: 0ms, 913 MB
    • generate chunks: 81ms, 925 MB
      • optimize chunks: 0ms, 920 MB
    • render chunks: 789ms, 998 MB
    • transform chunks: 16ms, 1.02 GB
    • generate bundle: 0ms, 1.02 GB

Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (7d8f3b3) to head (f699171).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5529   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         238      238           
  Lines        9544     9544           
  Branches     2439     2439           
=======================================
  Hits         9431     9431           
  Misses         48       48           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit 38114c4 into master May 26, 2024
@lukastaegert lukastaegert deleted the use-built-in-spans branch May 26, 2024 16:46
Copy link

github-actions bot commented Jul 8, 2024

This PR has been released as part of [email protected]. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant