-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: implementing decorator support #5562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#feat/decorator Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Performance report!Rough benchmark
Internal benchmark
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5562 +/- ##
=======================================
Coverage 99.04% 99.05%
=======================================
Files 238 241 +3
Lines 9256 9273 +17
Branches 2441 2444 +3
=======================================
+ Hits 9168 9185 +17
Misses 58 58
Partials 30 30 ☔ View full report in Codecov by Sentry. |
Hi Lukas, do you have any idea how to fix the failed tests? I added some log info for debugging and found that the AST of |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #5553
Description
This PR does not account for decorators with auto-accessor properties because this protocol has only reached Stage 1 at the moment.