Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: fix the noConflict option in REPL. #5611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2024
Merged

chore: fix the noConflict option in REPL. #5611

merged 1 commit into from
Aug 18, 2024

Conversation

7086cmd
Copy link
Contributor

@7086cmd 7086cmd commented Aug 11, 2024 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

nope

Description

In the REPL, the noConflict option is erroneously written as noConflice.

options

Rollup completed with warnings:
Unknown output options: noConflice. Allowed options: amd, assetFileNames, banner, chunkFileNames, compact, dir, dynamicImportInCjs, entryFileNames, esModule, experimentalMinChunkSize, exports, extend, externalImportAssertions, externalImportAttributes, externalLiveBindings, file, footer, format, freeze, generatedCode, globals, hashCharacters, hoistTransitiveImports, importAttributesKey, indent, inlineDynamicImports, interop, intro, manualChunks, minifyInternalExports, name, noConflict, outro, paths, plugins, preserveModules, preserveModulesRoot, reexportProtoFromExternal, sanitizeFileName, sourcemap, sourcemapBaseUrl, sourcemapExcludeSources, sourcemapFile, sourcemapFileNames, sourcemapIgnoreList, sourcemapPathTransform, strict, systemNullSetters, validate

@vercel Vercel
Copy link

vercel bot commented Aug 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2024 2:14am

@codecov Codecov
Copy link

codecov bot commented Aug 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.05%. Comparing base (c6751ff) to head (8bc504b).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5611   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         242      242           
  Lines        9311     9311           
  Branches     2466     2466           
=======================================
  Hits         9223     9223           
  Misses         58       58           
  Partials       30       30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lukastaegert
lukastaegert approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, much appreciated!

@lukastaegert lukastaegert added this pull request to the merge queue Aug 18, 2024
Merged via the queue into rollup:master with commit 811ef57 Aug 18, 2024
37 checks passed
@github-actions GitHub Actions
Copy link

This PR has been released as part of [email protected]. You can test it via npm install rollup.

@7086cmd 7086cmd deleted the fix/repl branch August 19, 2024 11:43
@YashGovekar YashGovekar mentioned this pull request Sep 8, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Sep 8, 2024
Open
This was referenced Sep 9, 2024
Open
Open
@AnthonyPorthouse AnthonyPorthouse mentioned this pull request Sep 10, 2024
Closed
@YashGovekar YashGovekar mentioned this pull request Sep 11, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Sep 12, 2024
Open
This was referenced Sep 12, 2024
Open
Open
Open
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 17, 2024
Open
This was referenced Sep 17, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 19, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 20, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Sep 21, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Sep 22, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Sep 22, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Sep 23, 2024
Open
This was referenced Sep 23, 2024
Open
Open
Open
This was referenced Sep 25, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 2, 2024
Open
Open
This was referenced Oct 4, 2024
Open
Open
@YashGovekar YashGovekar mentioned this pull request Oct 4, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Oct 4, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Oct 5, 2024
Open
This was referenced Oct 13, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@7086cmd @lukastaegert