Thanks to visit codestin.com
Credit goes to github.com

Skip to content

include all properties if a rest element is destructed #5833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2025
Merged

include all properties if a rest element is destructed #5833

merged 2 commits into from
Feb 5, 2025

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Feb 5, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5832

Description

@vercel Vercel
Copy link

vercel bot commented Feb 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 2:24pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/5832

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-qcjxuo2a5-rollup-js.vercel.app/repl/?pr=5833

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

Performance report

  • BUILD: 7208ms, 748 MB
    • initialize: 0ms, 28.1 MB
    • generate module graph: 2790ms, 560 MB
      • generate ast: 1273ms, 553 MB
    • sort and bind modules: 404ms, 606 MB
    • mark included statements: 4013ms, 748 MB
      • treeshaking pass 1: 2368ms, 742 MB
      • treeshaking pass 2: 466ms, 746 MB
      • treeshaking pass 3: 398ms, 750 MB
      • treeshaking pass 4: 388ms, 746 MB
      • treeshaking pass 5: 384ms, 748 MB
  • GENERATE: 738ms, 989 MB
    • initialize render: 0ms, 884 MB
    • generate chunks: 72ms, 894 MB
      • optimize chunks: 0ms, 890 MB
    • render chunks: 650ms, 964 MB
    • transform chunks: 16ms, 989 MB
    • generate bundle: 0ms, 989 MB

@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.53%. Comparing base (ac8b06a) to head (905f361).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ast/nodes/ObjectPattern.ts 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5833      +/-   ##
==========================================
- Coverage   98.54%   98.53%   -0.02%     
==========================================
  Files         269      269              
  Lines        8537     8544       +7     
  Branches     1463     1466       +3     
==========================================
+ Hits         8413     8419       +6     
- Misses         92       93       +1     
  Partials       32       32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lukastaegert
lukastaegert approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@lukastaegert lukastaegert merged commit cf54603 into master Feb 5, 2025
39 of 41 checks passed
@lukastaegert lukastaegert deleted the fix/5832 branch February 5, 2025 21:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

This PR has been released as part of [email protected]. You can test it via npm install rollup.

@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Destructuring assignment with Rest property behaves incorrectly when treeShake.propertyReadSideEffects is true or false
2 participants
@TrickyPi @lukastaegert