fix: don't optimize in with syntheticNamedExports
#6052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
TrickyPi
reviewed
Aug 5, 2025
test/form/samples/namespace-optimization-in-operator-synthetic/_config.js
Outdated
Show resolved
Hide resolved
TrickyPi
approved these changes
Aug 18, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6052 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 271 271
Lines 10598 10599 +1
Branches 2830 2831 +1
=======================================
+ Hits 10470 10471 +1
Misses 88 88
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukastaegert
approved these changes
Aug 20, 2025
|
This PR has been released as part of [email protected]. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
innamespace tree shake works incorrectly with commonjs plugin #6050Description
Similar to #6041 addressed
ExternalVariable, this PR also guards against optimizingSyntheticNamedExportVariable. I'm not sure if this can be accurately tree-shaken with proper analysis, but for now, this simply bails out optimization to keep the previous behavior and avoid breakage.