Disable local_dynamic_tls for OpenHarmony #6115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6115 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 271 271
Lines 10641 10641
Branches 2848 2848
=======================================
Hits 10507 10507
Misses 89 89
Partials 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukastaegert
approved these changes
Sep 19, 2025
|
This PR has been released as part of [email protected]. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
On the OpenHarmony platform, if I use a Node.js that is statically linked with libc++ (built with the --partly-static parameter) to load rollup, it works smoothly.
However, if I use a Node.js that is dynamically linked with libc++ (built with the default parameters) to load rollup, it will encounter the following error:
To avoid this error, we have two options to choose from:
To improve the compatibility of rollup on OpenHarmony and reduce maintenance costs, I chose option 1. This solution also refers to the handling in rolldown(rolldown/rolldown#5258).