Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gold: accept only base64 data URLs for image analyse and historical uploads #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vizsatiz merged 1 commit into from
Mar 26, 2026
Merged

gold: accept only base64 data URLs for image analyse and historical uploads #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 2 additions & 43 deletions wavefront/server/modules/gold_module/gold_module/controllers/image_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import base64
import re
import httpx

from common_module.common_container import CommonContainer
from common_module.response_formatter import ResponseFormatter
Expand Down Expand Up @@ -54,31 +53,11 @@ async def process_image(
'Invalid base64 image encoding'
),
)
elif image_str.startswith('http://') or image_str.startswith('https://'):
# Download the image from the URL
try:
async with httpx.AsyncClient() as client:
resp = await client.get(image_str)
if resp.status_code != 200:
return JSONResponse(
status_code=status.HTTP_400_BAD_REQUEST,
content=response_formatter.buildErrorResponse(
'Failed to download image from URL'
),
)
gold_image = resp.content
except Exception:
return JSONResponse(
status_code=status.HTTP_400_BAD_REQUEST,
content=response_formatter.buildErrorResponse(
'Error downloading image from URL'
),
)
else:
return JSONResponse(
status_code=status.HTTP_400_BAD_REQUEST,
content=response_formatter.buildErrorResponse(
'Image must be a data URL or a direct image URL'
'Image must be a data URL (data:image/<type>;base64,<data>)'
),
)
if not gold_image:
Expand Down Expand Up @@ -119,31 +98,11 @@ async def upload_historical_images(
'Invalid base64 image encoding'
),
)
elif image_str.startswith('http://') or image_str.startswith('https://'):
# Download the image from the URL
try:
async with httpx.AsyncClient() as client:
resp = await client.get(image_str)
if resp.status_code != 200:
return JSONResponse(
status_code=status.HTTP_400_BAD_REQUEST,
content=response_formatter.buildErrorResponse(
'Failed to download image from URL'
),
)
gold_image = resp.content
except Exception:
return JSONResponse(
status_code=status.HTTP_400_BAD_REQUEST,
content=response_formatter.buildErrorResponse(
'Error downloading image from URL'
),
)
else:
return JSONResponse(
status_code=status.HTTP_400_BAD_REQUEST,
content=response_formatter.buildErrorResponse(
'Image must be a data URL or a direct image URL'
'Image must be a data URL (data:image/<type>;base64,<data>)'
),
)
if not gold_image:
Expand Down
Loading