wavefront/server/plugins/authenticator/authenticator/microsoft_oauth/authenticator.py (1)

170-170: 💤 Low value

Consider making the prompt parameter configurable.

The prompt value is now hardcoded to select_account, which forces account selection for all OAuth flows. While this may be the desired default behavior for security reasons, consider making it configurable through MicrosoftOAuthConfig to allow flexibility for different deployment scenarios (e.g., some environments might prefer login or want to omit the parameter entirely).

♻️ Proposed approach to make prompt configurable

Add a prompt field to the config class with a sensible default:

# In config.py (MicrosoftOAuthConfig)
prompt: str = 'select_account'

Then reference it in the method:

         params = {
             'response_type': self.config.response_type,
             'client_id': self.config.client_id,
             'redirect_uri': self.config.redirect_uri,
             'scope': ' '.join(self.config.scopes),
             'state': state,
             'response_mode': self.config.response_mode,
-            'prompt': 'select_account',
+            'prompt': self.config.prompt,
         }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@wavefront/server/plugins/authenticator/authenticator/microsoft_oauth/authenticator.py`
at line 170, The hardcoded 'prompt': 'select_account' in the authorization
parameter construction should be made configurable: add a prompt: str =
'select_account' (or Optional[str] = None if you want to allow omission) to
MicrosoftOAuthConfig, update any config parsing/validation to include the new
field, and replace the literal 'prompt' usage in the method that builds the auth
URL (e.g., the function in authenticator.py that assembles authorize_params /
build_authorization_url) to read the value from MicrosoftOAuthConfig and only
include the parameter when the config value is non-empty; also update
docstrings/tests that assume the previous hardcoded behavior.