Rotating logger preserves file mode and ACL #1779
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/packit test rpm-software-management/dnf5#2494 |
This checks that the rotating logger preserves file mode and file access control list which a user set on the log file before executing dnf. It enables a test for the file mode and adds a new test for ACL. Because log rotation only works outside of installroot, it adds no_installroot tag to the tests. For: rpm-software-management/dnf5#1820 For: rpm-software-management/dnf5#2487
|
The code was merged. I don't know why packit did not use code from the linked pull request. I will reschedule the test after the code reaches nightly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks that the rotating logger preserves file mode and file access control list which a user set on the log file before executing dnf.
It enables a test for the file mode and adds a new test for ACL.
Because log rotation only works outside of installroot, it adds no_installroot tag to the tests.
Because behave fails to execute multiple no_installroot scenarios from one feature file, it moves them into separate files.
For: rpm-software-management/dnf5#1820
For: rpm-software-management/dnf5#2487
Requires: rpm-software-management/dnf5#2494