Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allowing parse to work with missing __doc__ #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2025
Merged

Allowing parse to work with missing __doc__ #103

merged 2 commits into from
Jul 25, 2025

Conversation

jamesbraza
Copy link
Contributor

mauvilsa
mauvilsa requested changes Jul 25, 2025
View reviewed changes
Copy link
Collaborator

@mauvilsa mauvilsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring-parser is currently supported in python 3.8 and 3.9, where the syntax | None is invalid. So the changes can't be like this, but using Optional[] instead.

@jamesbraza
Copy link
Contributor Author

docstring-parser is currently supported in python 3.8 and 3.9, where the syntax | None is invalid.

Ah I see, just pushed a change to typing.Optional 👌

@jamesbraza jamesbraza requested a review from mauvilsa July 25, 2025 06:20
@mauvilsa mauvilsa merged commit b4a3c48 into rr-:master Jul 25, 2025
21 checks passed
@jamesbraza jamesbraza deleted the optional-str branch July 25, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauvilsa mauvilsa mauvilsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @mauvilsa