Thanks to visit codestin.com
Credit goes to github.com

Skip to content

attempts to preserve substring indentation #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

attempts to preserve substring indentation #52

wants to merge 1 commit into from

Conversation

ntjess
Copy link

@ntjess ntjess commented Aug 2, 2021

The tests pass, but I have no idea if I did it the right way. Hoping this is easy enough for someone more experienced to pick up.

rr-
rr- requested changes Aug 3, 2021
View reviewed changes
Copy link
Owner

@rr- rr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create separate tests for strip_initial_whitespace function. Also I don't quite understand its purpose, which tests will help with.

CI is failing on style checks. https://github.com/rr-/docstring_parser/#contributing

@rr-
Copy link
Owner

rr- commented Aug 3, 2021 •
edited
Loading

Also in Google style if we have:

    """Arguments:
        argument: long description,
            long description 2
    """

I'd expect long description 2 to be indented with 4 spaces (relative to the outer scope that is the argument), and currently it's still indented with 8 (that is relative to the global scope of Arguments:).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rr- rr- rr- requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optionally preserve sub-indentation while parsing?
2 participants
@ntjess @rr-