issue: fix nil pointer dereference on plumb error #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plumbserve() fails with a nil pointer dereference when it tries to print errors via w.Err(). This happens because w is a dummy window with a nil *acme.Win. This commit replaces w.Err() calls in plumbserve() with acme.Errf(). It also extracts the plumbserve() method out of *awin, given that the previous change removes this dependency. Fixes issue rsc#5.
Document "githubissue" plumb port requirement and how to create it under the section "Acme Editor Integration".
a625765 to
087a7d8
Compare
|
The initial version of the PR was using |
|
Got halfway implementing this same patch then found this one. Thanks @jroimartin :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plumbserve() fails with a nil pointer dereference when it tries to
print errors via w.Err(). This happens because w is a dummy window
with a nil *acme.Win. This commit replaces w.Err() calls in
plumbserve() with acme.Errf(). It also extracts the plumbserve()
method out of *awin, given that the previous change removes this
dependency.
This PR also documents "githubissue" plumb port requirement and how to create
it under the section "Acme Editor Integration".
Fixes issue #5.