Use @remix-run/node-fetch-server in dev server#33
Conversation
Summary of ChangesHello @ScriptedAlchemy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the development server's request handling mechanism to leverage Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully updates the dev server to use @remix-run/node-fetch-server, moving away from a deprecated package. The changes in src/dev-server.ts are well-reasoned. I've suggested a small improvement to make the dynamic imports more robust. Otherwise, the changes look good.
src/dev-server.ts
Outdated
| const [{ createRequestHandler }, { createRequestListener }] = await Promise.all([ | ||
| import('react-router'), | ||
| import('@remix-run/node-fetch-server'), | ||
| ]); |
There was a problem hiding this comment.
This destructuring is a bit fragile as it relies on the order of modules in Promise.all. If someone accidentally reorders the imports, it could lead to a runtime error. A safer approach is to destructure in separate steps to make the code more robust and maintainable.
| const [{ createRequestHandler }, { createRequestListener }] = await Promise.all([ | |
| import('react-router'), | |
| import('@remix-run/node-fetch-server'), | |
| ]); | |
| const [reactRouter, remixNodeFetchServer] = await Promise.all([ | |
| import('react-router'), | |
| import('@remix-run/node-fetch-server'), | |
| ]); | |
| const { createRequestHandler } = reactRouter; | |
| const { createRequestListener } = remixNodeFetchServer; |
Implements the intent of #28 on top of current
mainby switching the internal dev-server middleware request listener to use@remix-run/node-fetch-serverdirectly (instead of going through@react-router/node's wrapper).Notes:
@mjackson/node-fetch-server, but React Router's@react-router/nodestill depends on it transitively as of v7.13.0.pnpm testpasses andpnpm buildsucceeds.