-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Improve copy UX on bs4_book (#1040) #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @keithmcnulty - thank you so much for this PR! We've gotten feedback that the button only being present on hover is confusing for users. Our technical writer actually missed the feature altogether b/c they didn't hover over the code block exactly. Would you be open to showing it by default but fading it (by adding some opacity), then darkening upon hover? For example: |
Hi @apreshill - I think that sounds reasonable. Although I think it’s important for a less obtrusive user experience only to enable this feature on input code chunks and not on output chunks. Would you like me to adjust the PR to reflect or is someone handling this on the RStudio side? Thanks! |
Thank you @keithmcnulty I'll ask around and respond here when I hear back. |
See #1040 (comment) We've done several improvement in several smaller PR that we have now merged. Please have a look ! This PR is now outdated but we are interesting by your feedback on the changes. Thank you! |
This PR is outdated by several others following discussion in #1040 Thanks @keithmcnulty ! |
Improves ux of copy to clipboard: