Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

keithmcnulty
Copy link

@keithmcnulty keithmcnulty commented Dec 7, 2020

Improves ux of copy to clipboard:

  1. Copy only appears on input code blocks
  2. Only on mouseover
  3. Copy button remains fixed during scroll
  4. Copy button repositioned marginally for better look on single code lines

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2020

CLA assistant check
All committers have signed the CLA.

@cderv cderv linked an issue Mar 31, 2021 that may be closed by this pull request
3 tasks
@apreshill apreshill added this to the v0.23 milestone Jun 2, 2021
@apreshill apreshill added the next to consider for next release label Jun 2, 2021
@apreshill
Copy link
Contributor

apreshill commented Jun 3, 2021

Hi @keithmcnulty - thank you so much for this PR! We've gotten feedback that the button only being present on hover is confusing for users. Our technical writer actually missed the feature altogether b/c they didn't hover over the code block exactly. Would you be open to showing it by default but fading it (by adding some opacity), then darkening upon hover? For example:

Screen Shot 2021-06-03 at 3 51 25 PM

@keithmcnulty
Copy link
Author

Hi @keithmcnulty - thank you so much for this PR! We've gotten feedback that the button only being present on hover is confusing for users. Our technical writer actually missed the feature altogether b/c they didn't hover over the code block exactly. Would you be open to showing it by default but fading it (by adding some opacity), then darkening upon hover? For example:

Screen Shot 2021-06-03 at 3 51 25 PM

Hi @apreshill - I think that sounds reasonable. Although I think it’s important for a less obtrusive user experience only to enable this feature on input code chunks and not on output chunks. Would you like me to adjust the PR to reflect or is someone handling this on the RStudio side? Thanks!

@apreshill
Copy link
Contributor

Thank you @keithmcnulty I'll ask around and respond here when I hear back.

@cderv
Copy link
Collaborator

cderv commented Jul 6, 2021

See #1040 (comment)

We've done several improvement in several smaller PR that we have now merged. Please have a look !

This PR is now outdated but we are interesting by your feedback on the changes. Thank you!

@cderv
Copy link
Collaborator

cderv commented Jul 13, 2021

This PR is outdated by several others following discussion in #1040

Thanks @keithmcnulty !

@cderv cderv closed this Jul 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bs4_book 🥾 next to consider for next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Less obtrusive copy to clipboards on bs4_book
4 participants