bs4_book: Copy button uses an icon instead of text #1192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same logic as Quarto
3 tasks
|
Here is what I'm thinking, will change the css to:
I think this will address issue #1040 pretty well. |
|
So something like this ? Currently, this style of button is used : https://getbootstrap.com/docs/4.0/components/buttons/#outline-buttons EDIT: it is now removed https://cderv.github.io/bs4booktesting/icon-copy-btn/ |
apreshill
approved these changes
Jul 2, 2021
Yes in #1187 after merging this and updating the PR. Keeping things separate in smaller PR seems better to me in order to change the different things on the copy button. @hadley does this icon and behavior looks ok to you ? |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apreshill as discussed.
I have used the same logic as Quarto, with icon built in (using inline svg). I have looked at the code there, and reuse part of it
I have kept the style of
bs4_book()though, with the tooltip and background, and just change the text by an icon, which changes in click for a few seconds.Example: https://cderv.github.io/bs4booktesting/icon-copy-btn/
We need to deal with the overlap discussed in #1187 (this PR could replace the other or complement only)