global option for console ANSI code behavior #1152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we unset |
|
It's probably good enough to just not set |
|
Ah yes, I even had doing that (unset TERM) written down on a piece of paper in front of me, then forgot about it. Already added the accessor on the server side! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New user preference to control Console's handling of ANSI escape characters. I'm not happy with the wording of these in the UI, so suggestions welcome as always:
Switching between these doesn't change anything already displayed, you need to refresh the IDE to have that happen, but will impact new output without refreshing.
Also added stub for server-side ANSI code processing; expect to implement this to have Notebooks deal with ANSI codes in published output (support them or at least strip them).