allow 'navigateToFile' to preserve position #1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23573b8 to
548dff3
Compare
jmcphers
reviewed
Jun 19, 2017
| // preserve whatever position was used in the document earlier | ||
| boolean navigateToPosition = | ||
| position != null && | ||
| (position.getLine() != -1 && position.getColumn() != -1); |
There was a problem hiding this comment.
Nit: Doesn't this treat any position with a -1 component as non-navigable rather than the -1, -1 special pair?
There was a problem hiding this comment.
You're right! Nice catch; I'll fix that up.
allow navigation when either is not -1
jmcphers
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for API calls of the form:
to preserve the preserve cursor position when the file "file" is opened. A corresponding change in the
rstudioapipackage will be made to take advantage of this behavior.rstudio/rstudioapi#48