Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

waehlisch
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #181 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   69.19%   69.06%   -0.14%     
==========================================
  Files          15       15              
  Lines        2227     2227              
==========================================
- Hits         1541     1538       -3     
- Misses        686      689       +3

CHANGELOG Outdated
* Version 0.6.0
- Change default symbol visibility: Hide all symbols per default,
export public symbols explicitly
- Change API for interval mode {set,get}_interval_mod and enumerations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the interval mode api is not officially released yet, therefore we should note it's addition not that it was changed within the dev cycle.

@waehlisch
Copy link
Member Author

@mroethke your comment is addressed.

Copy link
Member

@mroethke mroethke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I just found a bug in the cmake install target, I'm investigating that right now and will report back shortly.
This it not related to this pr but should be resolved before releasing 0.6.0, so I'm blocking this PR again.

@waehlisch
Copy link
Member Author

@mroethke #182 is now merged. Everything fine?

@waehlisch waehlisch merged commit 421a523 into rtrlib:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants