-
Notifications
You must be signed in to change notification settings - Fork 37
check-exports.sh: add more functions to ignorelist #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add the following functions to the ignorelist in check-exports.sh: - __gcov_error_file - __gcov_kvp_dynamic_pool - __gcov_kvp_dynamic_pool_index - __gcov_kvp_dynamic_pool_size - mangle_path
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/ This is a comment from an automated CI system. Warnings Generated during build:Ubuntu 20.04 arm8: Successful with additional warningsDebian Package lintian failed for Ubuntu 20.04 arm8:
Ubuntu 18.04 arm8: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 arm8:
Ubuntu 18.04 ppc64le: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 ppc64le:
Debian 8 amd64: Successful with additional warningsDebian Package lintian failed for Debian 8 amd64:
Ubuntu 16.04 arm7: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 arm7:
Debian 11 amd64: Successful with additional warningsDebian Package lintian failed for Debian 11 amd64:
Ubuntu 16.04 arm8: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 arm8:
Debian 9 amd64: Successful with additional warningsDebian Package lintian failed for Debian 9 amd64:
Ubuntu 16.04 amd64: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 amd64:
Ubuntu 16.04 i386: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 i386:
Ubuntu 18.04 i386: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 i386:
Ubuntu 18.04 amd64: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 amd64:
Debian 9 arm7: Successful with additional warningsDebian Package lintian failed for Debian 9 arm7:
Ubuntu 14.04 amd64: Successful with additional warningsDebian Package lintian failed for Ubuntu 14.04 amd64:
Debian 9 arm8: Successful with additional warningsDebian Package lintian failed for Debian 9 arm8:
Debian 10 amd64: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64:
Ubuntu 18.04 arm7: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 arm7:
|
I think a better solution would be to not do the exports check on a gcov enabled binary. |
Contribution description
travis.sh
fails locally after executingcheck-exports.sh
with themake gcov
setup. Not sure if this is even a problem.Adding the following functions to the ignorelist in
check-exports.sh
fixes the problem:__gcov_error_file
__gcov_kvp_dynamic_pool
__gcov_kvp_dynamic_pool_index
__gcov_kvp_dynamic_pool_size
mangle_path
Issues/PRs references
Fixes #263