rtr: Fix incomplete undo after failed table update #281

carl-tud · 2023-11-15T19:08:26Z

Contribution description

This PR restructures rtr_sync_receive_and_store_pdus in order to fully complete an undo operation after a failed update to the prefix or spki table. Currently, changes to the respective tables are not entirely reverted if a single table undo fails. The update and undo logic was moved into separate functions, making rtr_sync_receive_and_store_pdus more comprehensible.

Additionally, this PR fixes a memory leak involving recv_loop_cleanup_args where the references to the PDUs saved temporarily aren't stored properly.

NetDEF-CI · 2023-11-15T19:10:53Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 20.04 arm8: Failed (click for details)

Make Debug failed for Ubuntu 20.04 arm8:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/U2004ARM8/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
 1292 |    struct pdu_end_of_data_v0 *eod_pdu = (struct pdu_end_of_data_v0 *)pdu_data;
make[2]: *** [CMakeFiles/rtrlib_static.dir/build.make:232: CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:700: CMakeFiles/rtrlib_static.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

Ubuntu 18.04 ppc64le: Failed (click for details)

Make Debug failed for Ubuntu 18.04 ppc64le:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/U1804PPC64LE/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
CMakeFiles/rtrlib.dir/build.make:374: recipe for target 'CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o' failed
make[2]: *** [CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o] Error 1
CMakeFiles/Makefile2:387: recipe for target 'CMakeFiles/rtrlib.dir/all' failed
Makefile:140: recipe for target 'all' failed
make[1]: *** [CMakeFiles/rtrlib.dir/all] Error 2
make: *** [all] Error 2

Ubuntu 18.04 arm8: Failed (click for details)

Make Debug failed for Ubuntu 18.04 arm8:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/U1804ARM8/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
CMakeFiles/rtrlib.dir/build.make:374: recipe for target 'CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o' failed
make[2]: *** [CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o] Error 1
CMakeFiles/Makefile2:387: recipe for target 'CMakeFiles/rtrlib.dir/all' failed
make[1]: *** [CMakeFiles/rtrlib.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

OpenBSD 7 amd64: Failed (click for details)

Make Debug failed for OpenBSD 7 amd64:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/OBSD6AMD64/ErrorLog/log_make_debug.txt)

[  1%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr_mgr.c.o
warning: unknown warning option '-Wfree-nonheap-object'; did you mean '-Wsequence-point'? [-Wunknown-warning-option]
warning: unknown warning option '-Werror=cast-function-type'; did you mean '-Werror=bad-function-cast'? [-Wunknown-warning-option]
2 warnings generated.
[  3%] Building C object CMakeFiles/rtrlib.dir/rtrlib/lib/utils.c.o
warning: unknown warning option '-Wfree-nonheap-object'; did you mean '-Wsequence-point'? [-Wunknown-warning-option]
warning: unknown warning option '-Werror=cast-function-type'; did you mean '-Werror=bad-function-cast'? [-Wunknown-warning-option]
2 warnings generated.
[  4%] Building C object CMakeFiles/rtrlib.dir/rtrlib/lib/alloc_utils.c.o

Debian 11 amd64: Failed (click for details)

Make Debug failed for Debian 11 amd64:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/DEB11AMD64/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
 1292 |    struct pdu_end_of_data_v0 *eod_pdu = (struct pdu_end_of_data_v0 *)pdu_data;
make[2]: *** [CMakeFiles/rtrlib_static.dir/build.make:251: CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:719: CMakeFiles/rtrlib_static.dir/all] Error 2
make: *** [Makefile:160: all] Error 2

FreeBSD 12 amd64: Failed (click for details)

Make Debug failed for FreeBSD 12 amd64:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/FBSD12AMD64/ErrorLog/log_make_debug.txt)

[  1%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr_mgr.c.o
warning: unknown warning option '-Wfree-nonheap-object'; did you mean '-Wsequence-point'? [-Wunknown-warning-option]
warning: unknown warning option '-Werror=cast-function-type'; did you mean '-Werror=bad-function-cast'? [-Wunknown-warning-option]
2 warnings generated.
[  3%] Building C object CMakeFiles/rtrlib.dir/rtrlib/lib/utils.c.o
warning: unknown warning option '-Wfree-nonheap-object'; did you mean '-Wsequence-point'? [-Wunknown-warning-option]
warning: unknown warning option '-Werror=cast-function-type'; did you mean '-Werror=bad-function-cast'? [-Wunknown-warning-option]
2 warnings generated.
[  4%] Building C object CMakeFiles/rtrlib.dir/rtrlib/lib/alloc_utils.c.o

Debian 10 amd64: Failed (click for details)

Make Debug failed for Debian 10 amd64:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/DEB10AMD64/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
make[2]: *** [CMakeFiles/rtrlib.dir/build.make:232: CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:393: CMakeFiles/rtrlib.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

FreeBSD 11 amd64: Failed (click for details)

Make Debug failed for FreeBSD 11 amd64:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/FBSD11AMD64/ErrorLog/log_make_debug.txt)

[  1%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr_mgr.c.o
warning: unknown warning option '-Wfree-nonheap-object'; did you mean '-Wsequence-point'? [-Wunknown-warning-option]
warning: unknown warning option '-Werror=cast-function-type'; did you mean '-Werror=bad-function-cast'? [-Wunknown-warning-option]
2 warnings generated.
[  3%] Building C object CMakeFiles/rtrlib.dir/rtrlib/lib/utils.c.o
warning: unknown warning option '-Wfree-nonheap-object'; did you mean '-Wsequence-point'? [-Wunknown-warning-option]
warning: unknown warning option '-Werror=cast-function-type'; did you mean '-Werror=bad-function-cast'? [-Wunknown-warning-option]
2 warnings generated.
[  4%] Building C object CMakeFiles/rtrlib.dir/rtrlib/lib/alloc_utils.c.o

Redhat 8 amd64: Failed (click for details)

Make Debug failed for Redhat 8 amd64:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/REDHAT8/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
make[2]: *** [CMakeFiles/rtrlib.dir/build.make:258: CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:469: CMakeFiles/rtrlib.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

Fedora 35 amd64: Failed (click for details)

__Unittests (make test) failed for Fedora 35 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/FEDORA35/ErrorLog/log_make_test_debug.txt

NetBSD 9 amd64: Failed (click for details)

Make Debug failed for NetBSD 9 amd64:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/NBSD7AMD64/ErrorLog/log_make_debug.txt)

[ 21%] Building C object CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function 'rtr_sync_receive_and_store_pdus':
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
*** Error code 1
Stop.
make[2]: stopped in /home/ci/cibuild.411/rtrlib-source
*** Error code 1
Stop.
make[1]: stopped in /home/ci/cibuild.411/rtrlib-source

Redhat 9 amd64: Failed (click for details)

__Unittests (make test) failed for Redhat 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/RH9BUILD/ErrorLog/log_make_test_debug.txt

Fedora 31 amd64: Failed (click for details)

Make Debug failed for Fedora 31 amd64:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/FED31BUILD/ErrorLog/log_make_debug.txt)

[ 21%] Building C object CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
 1292 |    struct pdu_end_of_data_v0 *eod_pdu = (struct pdu_end_of_data_v0 *)pdu_data;
make[2]: *** [CMakeFiles/rtrlib_static.dir/build.make:252: CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:639: CMakeFiles/rtrlib_static.dir/all] Error 2
make: *** [Makefile:161: all] Error 2

Fedora 29 amd64: Failed (click for details)

Make Debug failed for Fedora 29 amd64:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/FEDORA29AMD64/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
make[2]: *** [CMakeFiles/rtrlib.dir/build.make:232: CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:393: CMakeFiles/rtrlib.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

Ubuntu 18.04 amd64: Failed (click for details)

Make Debug failed for Ubuntu 18.04 amd64:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/U1804AMD64/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
CMakeFiles/rtrlib.dir/build.make:374: recipe for target 'CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o' failed
make[2]: *** [CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o] Error 1
CMakeFiles/Makefile2:387: recipe for target 'CMakeFiles/rtrlib.dir/all' failed
Makefile:140: recipe for target 'all' failed
make[1]: *** [CMakeFiles/rtrlib.dir/all] Error 2
make: *** [all] Error 2

Ubuntu 18.04 i386: Failed (click for details)

Make Debug failed for Ubuntu 18.04 i386:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/U18I386/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
CMakeFiles/rtrlib_static.dir/build.make:374: recipe for target 'CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o' failed
make[2]: *** [CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o] Error 1
CMakeFiles/Makefile2:451: recipe for target 'CMakeFiles/rtrlib_static.dir/all' failed
make[1]: *** [CMakeFiles/rtrlib_static.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

CentOS 7 amd64: Failed (click for details)

Make Debug failed for CentOS 7 amd64:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/CENTOS7AMD64/ErrorLog/log_make_debug.txt)

[ 27%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
make[2]: *** [CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o] Error 1
make[1]: *** [CMakeFiles/rtrlib.dir/all] Error 2
make: *** [all] Error 2

Ubuntu 18.04 arm7: Failed (click for details)

Make Debug failed for Ubuntu 18.04 arm7:
(see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/U1804ARM7/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
CMakeFiles/rtrlib_static.dir/build.make:374: recipe for target 'CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o' failed
make[2]: *** [CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o] Error 1
CMakeFiles/Makefile2:451: recipe for target 'CMakeFiles/rtrlib_static.dir/all' failed
make[1]: *** [CMakeFiles/rtrlib_static.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

NetDEF-CI · 2023-11-15T19:42:30Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 20.04 arm8: Failed (click for details)

__Unittests (make test) failed for Ubuntu 20.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/U2004ARM8/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 arm8: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/U1804ARM8/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 ppc64le: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 ppc64le__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/U1804PPC64LE/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 amd64: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/U1804AMD64/ErrorLog/log_make_test_debug.txt

Debian 11 amd64: Failed (click for details)

__Unittests (make test) failed for Debian 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/DEB11AMD64/ErrorLog/log_make_test_debug.txt

FreeBSD 12 amd64: Failed (click for details)

__Unittests (make test) failed for FreeBSD 12 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/FBSD12AMD64/ErrorLog/log_make_test_debug.txt

OpenBSD 7 amd64: Failed (click for details)

__Unittests (make test) failed for OpenBSD 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/OBSD6AMD64/ErrorLog/log_make_test_debug.txt

Redhat 8 amd64: Failed (click for details)

__Unittests (make test) failed for Redhat 8 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/REDHAT8/ErrorLog/log_make_test_debug.txt

FreeBSD 11 amd64: Failed (click for details)

__Unittests (make test) failed for FreeBSD 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/FBSD11AMD64/ErrorLog/log_make_test_debug.txt

NetBSD 9 amd64: Failed (click for details)

__Unittests (make test) failed for NetBSD 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/NBSD7AMD64/ErrorLog/log_make_test_debug.txt

Fedora 35 amd64: Failed (click for details)

__Unittests (make test) failed for Fedora 35 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/FEDORA35/ErrorLog/log_make_test_debug.txt

Redhat 9 amd64: Failed (click for details)

__Unittests (make test) failed for Redhat 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/RH9BUILD/ErrorLog/log_make_test_debug.txt

Fedora 31 amd64: Failed (click for details)

__Unittests (make test) failed for Fedora 31 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/FED31BUILD/ErrorLog/log_make_test_debug.txt

Debian 10 amd64: Failed (click for details)

__Unittests (make test) failed for Debian 10 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/DEB10AMD64/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 arm7: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 arm7__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/U1804ARM7/ErrorLog/log_make_test_debug.txt

Fedora 29 amd64: Failed (click for details)

__Unittests (make test) failed for Fedora 29 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/FEDORA29AMD64/ErrorLog/log_make_test_debug.txt

CentOS 7 amd64: Failed (click for details)

__Unittests (make test) failed for CentOS 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/CENTOS7AMD64/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 i386: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 i386__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/U18I386/ErrorLog/log_make_test_debug.txt

carl-tud · 2023-11-15T19:51:03Z

test_live_validation and test_dynamic_groups seem to fail for rtrlib:master, too (gcc 11.4.0, Ubuntu 22.04, arm64)
edit: rpki-validator.realmv6.org refuses connection, seems to be down

waehlisch · 2023-11-15T20:40:00Z

thanks @carl-tud. yes, rpki-validator.realmv6.org is down. i will check later.

waehlisch · 2023-11-18T15:15:42Z

brief update: we will set up a new validator, but it will take some days due to internal clearance procedures. @Nimuedaertya will take care of this.

mroethke

Looks good on a cursory glance and does seem to work, but I won't have time to do a thorough review for at least several weeks.

waehlisch · 2023-11-21T19:58:23Z

@carl-tud can you rebase? the tests should pass now (see #282).

NetDEF-CI · 2023-11-23T18:49:57Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Fedora 35 amd64: Failed (click for details)

__Unittests (make test) failed for Fedora 35 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/FEDORA35/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 arm7: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 arm7__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/U1804ARM7/ErrorLog/log_make_test_debug.txt

Redhat 8 amd64: Failed (click for details)

__Unittests (make test) failed for Redhat 8 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/REDHAT8/ErrorLog/log_make_test_debug.txt

Fedora 29 amd64: Failed (click for details)

__Unittests (make test) failed for Fedora 29 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/FEDORA29AMD64/ErrorLog/log_make_test_debug.txt

NetBSD 9 amd64: Failed (click for details)

__Unittests (make test) failed for NetBSD 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/NBSD7AMD64/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 i386: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 i386__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/U18I386/ErrorLog/log_make_test_debug.txt

Debian 12 amd64: Failed (click for details)

__Unittests (make test) failed for Debian 12 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/D12AMD64/ErrorLog/log_make_test_debug.txt

Ubuntu 20.04 arm8: Failed (click for details)

__Unittests (make test) failed for Ubuntu 20.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/U2004ARM8/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 arm8: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/U1804ARM8/ErrorLog/log_make_test_debug.txt

OpenBSD 7 amd64: Failed (click for details)

__Unittests (make test) failed for OpenBSD 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/OBSD6AMD64/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 amd64: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/U1804AMD64/ErrorLog/log_make_test_debug.txt

CentOS 7 amd64: Failed (click for details)

__Unittests (make test) failed for CentOS 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/CENTOS7AMD64/ErrorLog/log_make_test_debug.txt

Fedora 31 amd64: Failed (click for details)

__Unittests (make test) failed for Fedora 31 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/FED31BUILD/ErrorLog/log_make_test_debug.txt

Redhat 9 amd64: Failed (click for details)

__Unittests (make test) failed for Redhat 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/RH9BUILD/ErrorLog/log_make_test_debug.txt

Debian 11 amd64: Failed (click for details)

__Unittests (make test) failed for Debian 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/DEB11AMD64/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 ppc64le: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 ppc64le__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/U1804PPC64LE/ErrorLog/log_make_test_debug.txt

FreeBSD 12 amd64: Failed (click for details)

__Unittests (make test) failed for FreeBSD 12 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/FBSD12AMD64/ErrorLog/log_make_test_debug.txt

FreeBSD 11 amd64: Failed (click for details)

__Unittests (make test) failed for FreeBSD 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/FBSD11AMD64/ErrorLog/log_make_test_debug.txt

Debian 10 amd64: Failed (click for details)

__Unittests (make test) failed for Debian 10 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/DEB10AMD64/ErrorLog/log_make_test_debug.txt

waehlisch · 2023-11-23T18:52:27Z

CI:rerun

waehlisch · 2023-11-24T10:05:57Z

CI:rerun

waehlisch · 2023-11-24T10:17:57Z

CI:rerun

waehlisch · 2023-11-24T10:24:10Z

CI:rerun

waehlisch · 2023-11-24T10:34:43Z

CI:rerun

NetDEF-CI · 2023-11-24T10:42:57Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-424/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Incomplete

Fedora 35 amd64: Incomplete

(check logs for details)

Ubuntu 18.04 i386: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 i386__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-424/artifact/U18I386/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 arm7: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 arm7__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-424/artifact/U1804ARM7/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 ppc64le: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 ppc64le__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-424/artifact/U1804PPC64LE/ErrorLog/log_make_test_debug.txt

Successful on other platforms/tests

NetBSD 9 amd64
Redhat 8 amd64
Fedora 29 amd64
Debian 12 amd64
Ubuntu 18.04 amd64
OpenBSD 7 amd64
Ubuntu 20.04 arm8
Ubuntu 18.04 arm8
CentOS 7 amd64
Redhat 9 amd64
Fedora 31 amd64
Debian 10 amd64
FreeBSD 12 amd64
Debian 11 amd64
FreeBSD 11 amd64

waehlisch · 2023-11-24T10:44:13Z

the results of the CI tests are very confusing. rerunning the CI leads to different results. sometimes the live test_live_validation and test_dynamic_groups fail, sometimes they pass. if make test outside of the CI, the tests always pass.

we should have stable CI tests before merging.

NetDEF-CI · 2023-11-24T10:47:58Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Incomplete

Redhat 8 amd64: Failed (click for details)

__Unittests (make test) failed for Redhat 8 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/REDHAT8/ErrorLog/log_make_test_debug.txt

Fedora 29 amd64: Failed (click for details)

__Unittests (make test) failed for Fedora 29 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/FEDORA29AMD64/ErrorLog/log_make_test_debug.txt

Redhat 9 amd64: Failed (click for details)

__Unittests (make test) failed for Redhat 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/RH9BUILD/ErrorLog/log_make_test_debug.txt

Fedora 31 amd64: Failed (click for details)

__Unittests (make test) failed for Fedora 31 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/FED31BUILD/ErrorLog/log_make_test_debug.txt

CentOS 7 amd64: Failed (click for details)

__Unittests (make test) failed for CentOS 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/CENTOS7AMD64/ErrorLog/log_make_test_debug.txt

OpenBSD 7 amd64: Failed (click for details)

__Unittests (make test) failed for OpenBSD 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/OBSD6AMD64/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 arm7: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 arm7__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/U1804ARM7/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 ppc64le: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 ppc64le__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/U1804PPC64LE/ErrorLog/log_make_test_debug.txt

Ubuntu 20.04 arm8: Failed (click for details)

__Unittests (make test) failed for Ubuntu 20.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/U2004ARM8/ErrorLog/log_make_test_release.txt

Ubuntu 18.04 arm8: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/U1804ARM8/ErrorLog/log_make_test_release.txt

Debian 11 amd64: Failed (click for details)

__Unittests (make test) failed for Debian 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/DEB11AMD64/ErrorLog/log_make_test_debug.txt

FreeBSD 12 amd64: Failed (click for details)

__Unittests (make test) failed for FreeBSD 12 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/FBSD12AMD64/ErrorLog/log_make_test_debug.txt

Debian 10 amd64: Failed (click for details)

__Unittests (make test) failed for Debian 10 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/DEB10AMD64/ErrorLog/log_make_test_debug.txt

FreeBSD 11 amd64: Failed (click for details)

__Unittests (make test) failed for FreeBSD 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/FBSD11AMD64/ErrorLog/log_make_test_debug.txt

Fedora 35 amd64: Incomplete

(check logs for details)

Successful on other platforms/tests

NetBSD 9 amd64
Debian 12 amd64
Ubuntu 18.04 i386
Ubuntu 18.04 amd64

waehlisch · 2023-11-24T10:49:22Z

my suggestion is that @Nimuedaertya creates a dummy PR that doesn't include any code changes to better understand what is going on with the CI.

NetDEF-CI · 2023-11-24T11:07:00Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Incomplete

Debian 12 amd64: Failed (click for details)

__Unittests (make test) failed for Debian 12 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/D12AMD64/ErrorLog/log_make_test_debug.txt

Fedora 31 amd64: Failed (click for details)

__Unittests (make test) failed for Fedora 31 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/FED31BUILD/ErrorLog/log_make_test_debug.txt

Redhat 9 amd64: Failed (click for details)

__Unittests (make test) failed for Redhat 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/RH9BUILD/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 amd64: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/U1804AMD64/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 i386: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 i386__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/U18I386/ErrorLog/log_make_test_debug.txt

Fedora 29 amd64: Failed (click for details)

__Unittests (make test) failed for Fedora 29 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/FEDORA29AMD64/ErrorLog/log_make_test_debug.txt

CentOS 7 amd64: Failed (click for details)

__Unittests (make test) failed for CentOS 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/CENTOS7AMD64/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 arm7: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 arm7__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/U1804ARM7/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 ppc64le: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 ppc64le__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/U1804PPC64LE/ErrorLog/log_make_test_debug.txt

Ubuntu 20.04 arm8: Failed (click for details)

__Unittests (make test) failed for Ubuntu 20.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/U2004ARM8/ErrorLog/log_make_test_release.txt

Ubuntu 18.04 arm8: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/U1804ARM8/ErrorLog/log_make_test_release.txt

OpenBSD 7 amd64: Failed (click for details)

__Unittests (make test) failed for OpenBSD 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/OBSD6AMD64/ErrorLog/log_make_test_debug.txt

Debian 10 amd64: Failed (click for details)

__Unittests (make test) failed for Debian 10 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/DEB10AMD64/ErrorLog/log_make_test_debug.txt

Debian 11 amd64: Failed (click for details)

__Unittests (make test) failed for Debian 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/DEB11AMD64/ErrorLog/log_make_test_debug.txt

FreeBSD 12 amd64: Failed (click for details)

__Unittests (make test) failed for FreeBSD 12 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/FBSD12AMD64/ErrorLog/log_make_test_debug.txt

Redhat 8 amd64: Failed (click for details)

__Unittests (make test) failed for Redhat 8 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/REDHAT8/ErrorLog/log_make_test_debug.txt

FreeBSD 11 amd64: Failed (click for details)

__Unittests (make test) failed for FreeBSD 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/FBSD11AMD64/ErrorLog/log_make_test_debug.txt

Fedora 35 amd64: Incomplete

(check logs for details)

NetBSD 9 amd64: Failed (click for details)

__Unittests (make test) failed for NetBSD 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/NBSD7AMD64/ErrorLog/log_make_test_debug.txt

carl-tud · 2023-11-24T11:14:15Z

At least for me, locally, test_live_validation and test_dynamic_groups are both finishing with exit code 0. When I tried running these tests yesterday (23/11/2023) evening, they failed because of an error PDU from the cache server (code 2, custom msg was something like "Running initial validation")

waehlisch · 2023-11-24T12:37:28Z

When I tried running these tests yesterday (23/11/2023) evening, they failed because of an error PDU from the cache server (code 2, custom msg was something like "Running initial validation")

yes, the validator was not running stable. we fixed this today morning.

carl-tud · 2023-11-29T12:40:14Z

CI:rerun

NetDEF-CI · 2023-11-29T13:04:57Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-432/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Incomplete

Ubuntu 18.04 ppc64le: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 ppc64le__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-432/artifact/U1804PPC64LE/ErrorLog/log_make_test_debug.txt

Ubuntu 18.04 arm7: Failed (click for details)

__Unittests (make test) failed for Ubuntu 18.04 arm7__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-432/artifact/U1804ARM7/ErrorLog/log_make_test_debug.txt

Fedora 35 amd64: Incomplete

(check logs for details)

Successful on other platforms/tests

Fedora 31 amd64
Redhat 9 amd64
Debian 10 amd64
FreeBSD 11 amd64
Fedora 29 amd64
CentOS 7 amd64
Ubuntu 18.04 amd64
Ubuntu 18.04 i386
FreeBSD 12 amd64
Debian 11 amd64
OpenBSD 7 amd64
NetBSD 9 amd64
Redhat 8 amd64
Ubuntu 20.04 arm8
Ubuntu 18.04 arm8
Debian 12 amd64

fho · 2024-04-01T08:46:07Z

@carl-tud what is the status of this PR?

carl-tud · 2024-04-15T07:59:45Z

The changes I‘ve made for this PR are included in #285 . This PR was just to get some of the changes not directly related ASPA, but the update logic out before the final ASPA PR. Do you think we should still merge this PR first?

fho · 2024-04-16T08:59:48Z

@carl-tud as you prefer :-)
Ideally we would get in these changes unrelated to ASPA with a separate PR.
If you don't want to bother it with and spend additional time with merge conflicts, etc, closing it and getting the changes in with #285 is also fine.
We should ensure that the fixes do not get lost in the changelog in that case.

If a table update fails, changes made to the prefix and spki table must be reverted/undone. If a table undo operation fails, changes to the other table should still be undone for a complete undo.

fixes a leak in `recv_loop_cleanup` where PDU pointers in `recv_loop_cleanup_args` are `NULL`.

carl-tud · 2024-05-22T15:59:24Z

@carl-tud as you prefer :-) Ideally we would get in these changes unrelated to ASPA with a separate PR. If you don't want to bother it with and spend additional time with merge conflicts, etc, closing it and getting the changes in with #285 is also fine. We should ensure that the fixes do not get lost in the changelog in that case.

Sorry for the late reply, in theory I'd be totally okay with that, but, reading #285 it looks like ASPA is going to be introduced as part of a new version (with potentially source-breaking changes), so this might be needed as bugfix for those temporarily staying on the older version..?

Nimuedaertya · 2024-06-11T17:02:26Z

CI:rerun

waehlisch · 2024-08-12T20:38:30Z

CI:rerun

Nimuedaertya · 2024-09-29T20:16:21Z

CI:rerun

edit:
somehow didnt work

waehlisch requested review from fho and mroethke November 15, 2023 19:09

waehlisch added priority:high type:bug type:enhancement labels Nov 15, 2023

carl-tud force-pushed the fix-update-undo branch from 370ebc4 to 34be75e Compare November 15, 2023 19:40

mroethke reviewed Nov 19, 2023

View reviewed changes

carl-tud force-pushed the fix-update-undo branch from 34be75e to 1bbb302 Compare November 23, 2023 18:47

rtrlib deleted a comment from NetDEF-CI Nov 24, 2023

carl-tud added 2 commits May 22, 2024 17:50

rtr: fix incomplete undo after failed update

2ac629e

If a table update fails, changes made to the prefix and spki table must be reverted/undone. If a table undo operation fails, changes to the other table should still be undone for a complete undo.

rtr: fix memory leak

dca9be9

fixes a leak in `recv_loop_cleanup` where PDU pointers in `recv_loop_cleanup_args` are `NULL`.

carl-tud force-pushed the fix-update-undo branch from 1bbb302 to dca9be9 Compare May 22, 2024 15:50

fho requested review from tanneberger and Nimuedaertya June 11, 2024 07:35

Nimuedaertya approved these changes Jun 22, 2024

View reviewed changes

fho assigned waehlisch Aug 12, 2024

tanneberger approved these changes Sep 28, 2024

View reviewed changes

rtr: Fix incomplete undo after failed table update #281

Are you sure you want to change the base?

rtr: Fix incomplete undo after failed table update #281

Uh oh!

Conversation

carl-tud commented Nov 15, 2023

Contribution description

Uh oh!

NetDEF-CI commented Nov 15, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Uh oh!

NetDEF-CI commented Nov 15, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Uh oh!

carl-tud commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

waehlisch commented Nov 15, 2023

Uh oh!

waehlisch commented Nov 18, 2023

Uh oh!

mroethke left a comment

Choose a reason for hiding this comment

Uh oh!

waehlisch commented Nov 21, 2023

Uh oh!

NetDEF-CI commented Nov 23, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Uh oh!

waehlisch commented Nov 23, 2023

Uh oh!

waehlisch commented Nov 24, 2023

Uh oh!

waehlisch commented Nov 24, 2023

Uh oh!

waehlisch commented Nov 24, 2023

Uh oh!

waehlisch commented Nov 24, 2023

Uh oh!

NetDEF-CI commented Nov 24, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Incomplete

Uh oh!

waehlisch commented Nov 24, 2023

Uh oh!

NetDEF-CI commented Nov 24, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Incomplete

Uh oh!

waehlisch commented Nov 24, 2023

Uh oh!

NetDEF-CI commented Nov 24, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Incomplete

Uh oh!

carl-tud commented Nov 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

waehlisch commented Nov 24, 2023

Uh oh!

carl-tud commented Nov 29, 2023

Uh oh!

NetDEF-CI commented Nov 29, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Incomplete

Uh oh!

fho commented Apr 1, 2024

Uh oh!

carl-tud commented Apr 15, 2024

Uh oh!

carl-tud commented Nov 15, 2023 •

edited

Loading

carl-tud commented Nov 24, 2023 •

edited

Loading

Nimuedaertya commented Sep 29, 2024 •

edited

Loading