Debugging Pipeline Errors #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nimuedaertya what is the plan for this PR? |
|
@fho Wanted to fix all errors which occur in the main branch during the ci-pipeline. Latest run of this PR |
|
@Nimuedaertya maybe you can be more specific, in case someone wants to help. |
|
Along with some code changes for more uniform code in the later named test cases, my issues/results can be summarized as follows: Handled Errors in this PR:
Unhandled errors
|
tanneberger
reviewed
Apr 21, 2024
| {NULL, 0, 0, 0} }; | ||
|
|
||
| const int connection_timeout = 20; | ||
| const int connection_timeout = 80; |
There was a problem hiding this comment.
why was it necessary to increase the timeout?
There was a problem hiding this comment.
live tests (test_live_validation, test_dynamic_groups) failed for some jobs, because rpki cache instance was busy with other requests.
|
CI: rerun |
tanneberger
approved these changes
May 2, 2024
Motivation
- get pipeline checks running
How:
- insert valid rpki-cache which runs also rtr
- edit url in live_tests, README
- modify changelog date in librtr.spec file
=> no changelog results in error, because all changes older
than 2years are dismissed
- add more output on failure for tests
Motivation: - test cases for arm7 Ubuntu18.04 and ppc64le Ubuntu18.04 failed - pipeline results in fail after commit - minor improvements for uniform build up live_tests How: - trie building is based on address (binary-trie) - getting a single bit for IPv6 addresses has been error prone for bit_postion > 95 - unsure why other distributions did not fail => may be due to different endianess
waehlisch
approved these changes
May 3, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
=> no changelog results in error, because all changes older than 2years are dismissed
Testing procedure