Fix: tommyds: ignore incorrect -Wfree-nonheap-object warnings by GCC
#301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- GCC 15 (and maybe other versions) reports warnings in the `tommyds` library about freeing non-heap objects when compiling RTRlib without debug options (`-D CMAKE_BUILD_TYPE=Release`), even though the code is correct. A GCC bug report for false-positives when the `-Wfree-nonheap-object` option is enabled can be found in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54202.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
#296 reports that with GCC 15 warnings for freeing non-heap objects are reported while compiling RTRlib.
I could reproduce the warnings when using a release build (
-D CMAKE_BUILD_TYPE=Release) for the reported version as well as on master. However, the warnings are false positives since the correct pointers (i.e. the pointers that were returned bytommy_calloc/tommy_malloc) are passed totommy_free.A quick search online revealed that GCC can report false positives when the
-Wfree-nonheap-objectoption is enabled (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54202).To remove the warning and avoid further bug reports in the future I disabled the warning for the respective lines in the C code by using the following GCC pragma construct:
Testing procedure
Issues/PRs references
Fixes #296