rtrlib: Make API consistent #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanneberger
requested changes
Jul 28, 2025
tanneberger
requested changes
Aug 3, 2025
- To avoid name clashes and have a consistent API naming, every function, enum, struct, ... that is exported is prefixed with `rtr_`/`RTR_`. - `int` return types are changed to the pertinent `enum` type if applicable. - Change `bool` type to indicate the performed operation when notifying users about changes in the SPKI and PFX tables to specific `enum` type to improve readability and make the API specification stricter. - Make names of validation functions consistent
tanneberger
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This pull request aims to make the public API of RTRlib more consistent. The following has been implemented/changed:
rtr_/RTR_.intreturn types are changed to the pertinentenumtype if applicable.booltype to indicate the performed operation when notifying users about changes in the SPKI and PFX tables to specificenumtype to improve readability and make the API specification stricter.Testing procedure
Since the functionality hasn't changed, no new tests were added. The existing tests can be run to quickly check for regressions:
Issues/PRs references
n/a