Fix memory leaks #316
Open
Fix memory leaks #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When running the tests with Valgrind it detected multiple memory leaks; some of them were caused by missing calls to `free()` in the tests cases but others were real memory leaks within the RTRlib.
- Previously, whenever an existing ASPA record was removed by a new one, the provider ASN list of the replaced record was not freed resulting in a memory leak. Now, whenever a record is replaced, it is temporarily stored and once the new ASPA record table was successfully created, the provider ASN list of each replaced record is freed.
tanneberger
requested changes
Aug 20, 2025
| @@ -0,0 +1,24 @@ | |||
| /* | |||
There was a problem hiding this comment.
why this config file?
Is this necessary, the RTRLIB_BGPSEC_ENABLED can also be passed via a command line to your compiler
There was a problem hiding this comment.
Good catch. This file is in the .gitignore and shouldn't be pushed. Idk how it got committed and pushed. I will remove it again.
| return RTR_SUCCESS; | ||
| } | ||
|
|
||
| static void make_key() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This pull request fixes multiple memory leaks in the test cases and the RTRlib itself. All fixed memory leaks have been found by running
valgrind --leak-check=full <path-to-test-case>.Note: One memory leak still exists in
test_dynamic_groups.c. To me it looks like it's caused by the test code and not the RTRlib and thus it can be fixed later.Note: Valgrind shows memory leaks (still reachable) for the tests that start new threads. These are, however, not caused by any code in the tests or RTRlib but by the C runtime and thus can be ignored or rather ignores should be created for those leaks in the future.
Testing procedure
Run
valgrind --leak-check=full <path-to-test-case>for each test with and without the changes of this pull request.Issues/PRs references
n/a