rtrlib/transport: change port from int to char in ssh transport #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 59.94% (diff: 0.00%)@@ master #89 diff @@
==========================================
Files 14 14
Lines 1911 1875 -36
Methods 141 141
Messages 0 0
Branches 390 358 -32
==========================================
- Hits 1147 1124 -23
+ Misses 764 751 -13
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #80 and applies comment by @shaddeus so that both
struct tr_tcp_configandstruct tr_ssh_confighandle port aschar *. However, now the tcp config is just a subset of ssh config, and hence somewhat redundant. Maybe we should have astruct tr_configand for SSH some extend struct?!Note: this PR makes
ssh_transport.hkernel coding style compliant, this file is added for testing too.