Add an option to allow enforcement of verified doubles in nameless doubles #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darhazer
approved these changes
Oct 3, 2018
| context 'when configured to ignore nameless doubles' do | ||
| let(:cop_config) { { 'IgnoreNameless' => true } } | ||
|
|
||
| it 'ignores doubles whose name is a symbol' do |
There was a problem hiding this comment.
the test description does not match its body
|
@Darhazer Thanks for the quick review, and sorry for the spec sloppiness. Those are fixed up now. |
Darhazer
reviewed
Oct 3, 2018
| @@ -53,14 +53,27 @@ | |||
| end | |||
| end | |||
|
|
|||
| it 'ignores doubles without a name' do | |||
| expect_no_offenses(<<-RUBY) | |||
| it 'finds a double when the no name is specified' do | |||
There was a problem hiding this comment.
this one needs improving. Perpahs finds a double without a name is enough
There was a problem hiding this comment.
doubles that have no name specified also works, as it is consistent with the other test
There was a problem hiding this comment.
👍 fixed that up.
…ubles
Currently if you have a double/spy with no name (or default stubs) it will never cause a violation according to the `RSpec/VerifiedDoubles` cop. This adds an optional configuration to allow violations to be added for code that looks like:
```
foo = double
allow(foo).to receive(:bar) do |arg1|
“#{arg1} based result”
end
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you have a double/spy with no name (or default stubs) it will never cause a violation according to the
RSpec/VerifiedDoublescop. This adds an optional configuration to allow violations to be added for code that looks like:I left the default configuration not enforcing this cop on nameless doubles so as to make this a non-breaking change.