Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve Base64.urlsafe_encode64 performance #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2021
Merged

Improve Base64.urlsafe_encode64 performance #5

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
544e0c2
Improve Base64.urlsafe_encode64 performance
jcmfernandes Sep 2, 2021
39e22ef
Simplify
jcmfernandes Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Improve Base64.urlsafe_encode64 performance 
Improves the method's performance when asked to remove padding.

str.delete!("=") iterates over the entire string looking for the equals
character, but we know that we will, at most, find two at the end of the
string.
  • Loading branch information
@jcmfernandes
jcmfernandes committed Sep 2, 2021
commit 544e0c2cf735acd5c61bd3d26247350fc7a86691
8 changes: 7 additions & 1 deletion lib/base64.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,14 @@ def strict_decode64(str)
# You can remove the padding by setting +padding+ as false.
def urlsafe_encode64(bin, padding: true)
str = strict_encode64(bin)
unless padding
if str.end_with?("==")
str.delete_suffix!("==")
elsif str.end_with?("=")
str.chop!
end
end
str.tr!("+/", "-_")
str.delete!("=") unless padding
str
end

Expand Down