Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fallback to Reline when require 'readline' fails#1076

Merged
tompng merged 1 commit into
ruby:masterfrom
tompng:readline_bundled_gem
Jan 27, 2025
Merged

Fallback to Reline when require 'readline' fails#1076
tompng merged 1 commit into
ruby:masterfrom
tompng:readline_bundled_gem

Conversation

@tompng
Copy link
Copy Markdown
Member

@tompng tompng commented Jan 26, 2025

Require readline may fail because it is a bundled gem in 3.5.0.dev.

@tompng
Fallback to Reline when require 'readline' fails
77d6069 
Require readline may fail because it is a bundled gem in 3.5.0.dev.
@hsbt hsbt mentioned this pull request Jan 27, 2025
Merged
tompng
tompng commented Jan 27, 2025
View reviewed changes
Comment thread lib/irb/input-method.rb
const_set(:Readline, ::Readline)
rescue LoadError
const_set(:Readline, ::Reline)
end
Copy link
Copy Markdown
Member Author

@tompng tompng Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds ReadlineInputMethod::Readline = ::Readline or ::Reline
because we don't want to pollute the top level by adding constant ::Readline when require 'readline' fails.

@tompng tompng merged commit 1ca7472 into ruby:master Jan 27, 2025
@tompng
Copy link
Copy Markdown
Member Author

tompng commented Jan 27, 2025

To use GNU readline, now we need to add both gem 'readline' and gem 'readline-ext' to Gemfile.

Maybe we can require "readline.#{RbConfig::CONFIG['DLEXT']}" instead of 'readline' (https://github.com/ruby/readline/blob/master/lib/readline.rb)
Then users only need to add readline-ext to Gemfile just as it has been before.

@tompng tompng deleted the readline_bundled_gem branch January 27, 2025 14:01
@st0012
Copy link
Copy Markdown
Member

st0012 commented Jan 27, 2025

Is there any feature that readline does better than reline? Does it make sense to still allow both types of input methods going forward 🤔

@tompng
Copy link
Copy Markdown
Member Author

tompng commented Jan 27, 2025

I didn't thought of that. Maybe it's time to use Reline also in "--singleline", "--readline", "--legacy" mode.

(Off topic: irb --readline was useful for me to check the difference between Reline and Readline while developing Reline)

@tompng tompng added the bug Something isn't working label Apr 3, 2025
@tompng tompng mentioned this pull request Apr 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tompng @st0012