✨ Add response_handlers kwarg to Net::IMAP.new
#419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There weren't any response_handler tests at all, prior to this!
3c0638c to
cf69acd
Compare
This ensures every server response is handled, including the greeting.
cf69acd to
071eed4
Compare
nevans
added a commit
that referenced
this pull request
Apr 17, 2025
…lers-kwarg ✨ Add `response_handlers` kwarg to `Net::IMAP.new` (backports #419)
This was referenced Apr 20, 2025
headius
added a commit
to headius/jruby
that referenced
this pull request
May 5, 2025
Security fixes were in 0.5.7 See https://github.com/ruby/net-imap/releases/tag/v0.5.7 * ruby/net-imap#419 * ruby/net-imap#444 The security advisory is at GHSA-j3g3-5qv5-52mj Release 0.5.8 includes additional improvements and fixes. See https://github.com/ruby/net-imap/releases/tag/v0.5.8
headius
added a commit
to headius/jruby
that referenced
this pull request
May 5, 2025
Security fixes were in 0.5.7 See https://github.com/ruby/net-imap/releases/tag/v0.5.7 * ruby/net-imap#419 * ruby/net-imap#444 The security advisory is at GHSA-j3g3-5qv5-52mj Release 0.5.8 includes additional improvements and fixes. See https://github.com/ruby/net-imap/releases/tag/v0.5.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
response_handlerskeyword argument toNet::IMAP.newassigns response handlers before the receiver thread is started. This ensures every server response is handled, including the greeting.