♻️ Extract ResponseReader from get_response
#433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's nice to extract a little bit of the complexity from the core `Net::IMAP` class. But my primary motivation was so that I could directly test this code quickly and in isolation from needing to simulate a full IMAP connection.
nevans
commented
Apr 18, 2025
Comment on lines
+7
to
+11
| attr_reader :client | ||
|
|
||
| def initialize(client, sock) | ||
| @client, @sock = client, sock | ||
| end |
There was a problem hiding this comment.
This version of the ResponseReader isn't actually using client yet, so I could've left that out of this PR. But upcoming PRs will need the client for passing to callbacks (and also for its config).
nevans
added a commit
that referenced
this pull request
Apr 19, 2025
♻️ Extract ResponseReader from get_response (backport #433)
This was referenced Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's nice to extract a little bit of the complexity from the core
Net::IMAPclass. But my primary motivation was so that I could directly test this code quickly and in isolation from needing to simulate a full IMAP connection.Note that, because it wraps
@sock, the ResponseReader must be recreated (or updated) when@sockis replaced for TLS (or, in the future, for theCOMPRESSextension).