More on tutorial #19
Merged
More on tutorial #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BurdetteLamar
commented
Apr 11, 2021
- Added to section on custom argument converters.
- Added introductory section.
| === Custom Argument Converters | ||
|
|
||
| An argument converter has: | ||
|
|
There was a problem hiding this comment.
Now the initial sentence "fights with" the following sentences, I think. Perhaps you can drop/reformulate, so that this sentence is linked to the bullet-point list.
There was a problem hiding this comment.
Now the initial sentence "fights with" the following sentences, I think. Perhaps you can drop/reformulate, so that this sentence is linked to the bullet-point list.
I have deleted 347-8, which I think fixes the problem.
There was a problem hiding this comment.
👍 Shiny and clear! Thanks!
| parser = OptionParser.new | ||
| parser.accept(:capitalize, /\w*/) do |value| | ||
| value.capitalize | ||
| end |
There was a problem hiding this comment.
TIL! This is so great, thanks for adding this set of examples.
olleolleolle
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
This explains converters, which is helpful! Thanks, @BurdetteLamar!
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.