Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

BurdetteLamar
Copy link
Member

  • Removed a largish block of repeated text.
  • Added sections "Top List and Base List" and "Methods for Defining Options" (on, define, etc.).
  • Linked from class OptionParser doc to the tutorial.

I'm not positive that we need the two sections, but it took be some work to learn and write, so let's consider them.

@BurdetteLamar BurdetteLamar added the documentation Improvements or additions to documentation label Apr 15, 2021
@BurdetteLamar
Copy link
Member Author

@olleolleolle, will you be looking at this?

@BurdetteLamar
Copy link
Member Author

@nobu, can you take a look at this PR? (I have a biggish block of RDoc about parsing that's waiting for this PR to clear.) Thanks.

@olleolleolle
Copy link
Contributor

@BurdetteLamar It's been a bit hectic, here and I've been far from computer screens when not at work. Soon!

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the additional context added by this PR!

The parts which say "these work like these other methods, but return differently" is especially good for the careful reader.

Added comma, as suggested.
@BurdetteLamar BurdetteLamar merged commit 7f3195b into ruby:master Apr 22, 2021
@BurdetteLamar
Copy link
Member Author

Thanks, @olleolleolle, for your careful reviews.

matzbot pushed a commit to ruby/ruby that referenced this pull request Jul 28, 2021
- Removed a largish block of repeated text.
- Added sections "Top List and Base List" and "Methods for Defining Options" (on, define, etc.).
- Linked from class OptionParser doc to the tutorial.

ruby/optparse@7f3195b9db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants