Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor Darkfish implementation #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Refactor Darkfish implementation #1300

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f4fffbe
Extract page files variable to ivar
st0012 Feb 20, 2025
180771e
Extract sidebar pages logic into helper methods
st0012 Feb 20, 2025
f675664
Refactor sidebar list generation methods
st0012 Feb 20, 2025
0a517de
Simplify sidebar ToC's generation logic
st0012 Feb 27, 2025
8ebaa94
Rename current local to target
st0012 Feb 27, 2025
5d0f26e
Remove unnecessary class page sidebar partial extraction
st0012 Feb 27, 2025
a5f0bf5
Simplify class page
st0012 Feb 27, 2025
4414b4f
Remove unnecessary ivars from darkfish
st0012 Feb 27, 2025
1d8fff1
Reuse @classes ivar in ToCs page
st0012 Mar 1, 2025
a8dee57
Avoid using block binding to capture template variables
st0012 Mar 1, 2025
56d7b63
Remove unused search_index_rel_prefix local
st0012 Mar 1, 2025
8373d70
Simplify rel_prefix locasls declaration
st0012 Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused search_index_rel_prefix local
  • Loading branch information
@st0012
st0012 committed Mar 2, 2025
commit 56d7b6364f2d79067ceb4b6300bfea4610f4b616
15 changes: 0 additions & 15 deletions lib/rdoc/generator/darkfish.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,9 +286,6 @@ def generate_index

out_file = @base_dir + @options.op_dir + 'index.html'
rel_prefix = @outputdir.relative_path_from out_file.dirname
search_index_rel_prefix = rel_prefix
search_index_rel_prefix += @asset_rel_path if @file_output

asset_rel_prefix = rel_prefix + @asset_rel_path

@title = @options.title
Expand Down Expand Up @@ -318,8 +315,6 @@ def generate_class klass, template_file = nil
debug_msg " working on %s (%s)" % [klass.full_name, klass.path]
out_file = @outputdir + klass.path
rel_prefix = @outputdir.relative_path_from out_file.dirname
search_index_rel_prefix = rel_prefix
search_index_rel_prefix += @asset_rel_path if @file_output

asset_rel_prefix = rel_prefix + @asset_rel_path

Expand Down Expand Up @@ -404,8 +399,6 @@ def generate_file_files
out_file = @outputdir + file.path
debug_msg " working on %s (%s)" % [file.full_name, out_file]
rel_prefix = @outputdir.relative_path_from out_file.dirname
search_index_rel_prefix = rel_prefix
search_index_rel_prefix += @asset_rel_path if @file_output

asset_rel_prefix = rel_prefix + @asset_rel_path

Expand Down Expand Up @@ -448,8 +441,6 @@ def generate_page file
out_file = @outputdir + file.path
debug_msg " working on %s (%s)" % [file.full_name, out_file]
rel_prefix = @outputdir.relative_path_from out_file.dirname
search_index_rel_prefix = rel_prefix
search_index_rel_prefix += @asset_rel_path if @file_output

target = file
asset_rel_prefix = rel_prefix + @asset_rel_path
Expand All @@ -475,8 +466,6 @@ def generate_servlet_not_found message
debug_msg "Rendering the servlet 404 Not Found page..."

rel_prefix = rel_prefix = ''
search_index_rel_prefix = rel_prefix
search_index_rel_prefix += @asset_rel_path if @file_output

asset_rel_prefix = ''

Expand Down Expand Up @@ -506,8 +495,6 @@ def generate_servlet_root installed

rel_prefix = '.'
asset_rel_prefix = rel_prefix
search_index_rel_prefix = asset_rel_prefix
search_index_rel_prefix += @asset_rel_path if @file_output

@title = 'Local RDoc Documentation'

Expand Down Expand Up @@ -535,8 +522,6 @@ def generate_table_of_contents

out_file = @outputdir + 'table_of_contents.html'
rel_prefix = @outputdir.relative_path_from out_file.dirname
search_index_rel_prefix = rel_prefix
search_index_rel_prefix += @asset_rel_path if @file_output

asset_rel_prefix = rel_prefix + @asset_rel_path

Expand Down