Refactor PR preview workflow for improved approval process #1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rdoc with
|
| Latest commit: |
d2cb4c7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://036ab080.rdoc-6cd.pages.dev |
| Branch Preview URL: | https://improve-preview-building-wor.rdoc-6cd.pages.dev |
1aecdfb to
b1c02db
Compare
Because GitHub Actions' manual dispatching doesn't allow pre-filling the PR number, it'd be tedious for maintainers to manually trigger the workflow. This refactor introduces a new workflow that checks for PRs from the main repository or forks, and if it's a fork, it requires approval to deploy. This works by associating the workflow with an environment that requires approval to deploy. The pr-review-check.yml workflow will then call the cloudflare-preview.yml workflow to build and deploy the preview.
b1c02db to
ba3a232
Compare
cad758f to
d2cb4c7
Compare
|
🚀 Preview deployment available at: https://ae7985bf.rdoc-6cd.pages.dev (commit: d2cb4c7) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because GitHub Actions' manual dispatching doesn't allow pre-filling the PR number, it'd be tedious for maintainers to manually trigger the workflow.
This refactor introduces a new workflow that checks for PRs from the main repository or forks, and if it's a fork, it requires approval to deploy. This works by associating the workflow with an environment that requires approval to deploy.
The pr-review-check.yml workflow will then call the cloudflare-preview.yml workflow to build and deploy the preview.