Implement end-of-history #826
Conversation
lib/reline/line_editor.rb
Outdated
| @@ -1654,6 +1654,12 @@ def finish | |||
| end | |||
| alias_method :next_history, :ed_next_history | |||
|
|
|||
| private def end_of_history(key) | |||
There was a problem hiding this comment.
I'm not sure of the naming convention. Should this be named ed_end_of_history? It seem like Editline supports that.
There was a problem hiding this comment.
ed_end_of_history looks good 👍. And we need to alias it to end_of_history
test/reline/test_key_actor_emacs.rb
Outdated
| Reline::HISTORY.concat(['abc', '123']) | ||
| input_keys("\C-rab\C-jd") | ||
| assert_line_around_cursor('d', 'abc') | ||
| # \M->: clear input, move history to end, keep edited line as previous history |
There was a problem hiding this comment.
Looks like \M-> in GNU Readline does not clear input. \C-rab is clearing the input and moves history pointer.
Can you change the test case to input "def", UP key, \M-> and check line around cursor to be "def", ""?
test/reline/test_key_actor_emacs.rb
Outdated
| input_key_by_symbol(:end_of_history) | ||
| assert_line_around_cursor('', '') | ||
| input_keys("\C-p") | ||
| assert_line_around_cursor('dabc', '') |
There was a problem hiding this comment.
It should be '123', ''
I tested with irb --readline (Readline::VERSION #=> 8.2)
lib/reline/line_editor.rb
Outdated
| @history_pointer = Reline::HISTORY.size - 1 | ||
| @line_backup_in_history ||= '' | ||
| ed_next_history(key) |
There was a problem hiding this comment.
move_history(Reline::HISTORY.size, line: :start, cursor: :end) is better.
Using move_history, we don't need to think of @line_index @line_backup_in_history and other internal structures.
There was a problem hiding this comment.
\M-< (beginning-of-history) is a pair of \M-> so implementing both would be awesome.
It could be in this pull request, separate pull request is also fine.
There was a problem hiding this comment.
I used line: :end because Readline moves the cursor at the end too, and to match the assertion you shared in #826 (comment).
Also implemented beginning-of-history.
I removed the assertions about the edited history lines, because the code doesn't touch that actually. And the fact that history lines can be edited can be configured with Readline with revert-all-at-newline. It's annoying when you edit a history line, run it, and you lose the original history line. Since it's something I'd like to have, I'd rather not hard-code that behavior in an unrelated test.
5d871ab to
7748af0
Compare
After using incremental search, I sometime want to go back to the end of history.
Reline is missing an implementation for
end-of-historyfrom Readline.This adds it.