Thanks to visit codestin.com
Credit goes to github.com

Skip to content

YJIT: rb_str_concat_literals is not leaf #10035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2024
Merged

YJIT: rb_str_concat_literals is not leaf #10035

merged 1 commit into from
Feb 21, 2024

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Feb 21, 2024 •
edited
Loading

As indicated by attr bool leaf = false; in insns.def, rb_str_concat_literals (concatstrings instruction) is not leaf. This PR fixes the setup to prepare for arbitrary method calls.

  -- C level backtrace information -------------------------------------------
  /Users/runner/work/ruby/ruby/build/ruby(rb_vm_bugreport+0xb60) [0x1050a6d5c] ../src/vm_dump.c:1151
  /Users/runner/work/ruby/ruby/build/ruby(rb_vm_bugreport) (null):0
  /Users/runner/work/ruby/ruby/build/ruby(rb_bug_without_die+0xf0) [0x104ebf048] ../src/error.c:1042
  /Users/runner/work/ruby/ruby/build/ruby(rb_bug+0x1c) [0x10549d400] ../src/error.c:1050
  /Users/runner/work/ruby/ruby/build/ruby(rb_vm_push_frame_fname.cold.1+0x0) [0x1054c160c] ../src/vm_insnhelper.c:281
  /Users/runner/work/ruby/ruby/build/ruby(rb_vm_check_canary.cold.1) (null):0
  /Users/runner/work/ruby/ruby/build/ruby(rb_vm_stack_canary+0x0) [0x10506fa38] ../src/vm_insnhelper.c:258
  /Users/runner/work/ruby/ruby/build/ruby(rb_vm_check_canary) (null):0
  /Users/runner/work/ruby/ruby/build/ruby(vm_push_frame+0x18c) [0x10506fd0c] ../src/vm_insnhelper.c:374
  /Users/runner/work/ruby/ruby/build/ruby(vm_call0_cfunc_with_frame+0x8c) [0x10509df00] ../src/vm_eval.c:167
  /Users/runner/work/ruby/ruby/build/ruby(vm_call0_cfunc) ../src/vm_eval.c:187
  /Users/runner/work/ruby/ruby/build/ruby(vm_call0_body) ../src/vm_eval.c:233
  /Users/runner/work/ruby/ruby/build/ruby(vm_call0_cc+0x120) [0x1050815f8] ../src/vm_eval.c:110
  /Users/runner/work/ruby/ruby/build/ruby(rb_call0+0x314) [0x10509ec5c]
  /Users/runner/work/ruby/ruby/build/ruby(rb_class_new_instance+0x50) [0x104f5c154] ../src/object.c:2184
  /Users/runner/work/ruby/ruby/build/ruby(rb_exc_new_str+0x40) [0x104ebfd50] ../src/error.c:1413
  /Users/runner/work/ruby/ruby/build/ruby(rb_vraise+0x28) [0x104ec33a4] ../src/error.c:3474
  /Users/runner/work/ruby/ruby/build/ruby(rb_warning_category_update+0x0) [0x104ebe24c] ../src/error.c:3482
  /Users/runner/work/ruby/ruby/build/ruby(rb_raise) (null):0
  /Users/runner/work/ruby/ruby/build/ruby(rb_str_buf_cat_ascii+0x0) [0x105012e7c] ../src/string.c:3364
  /Users/runner/work/ruby/ruby/build/ruby(rb_enc_cr_str_buf_cat) (null):0
  /Users/runner/work/ruby/ruby/build/ruby(RB_BUILTIN_TYPE+0x0) [0x105013150] ../src/string.c:3426
  /Users/runner/work/ruby/ruby/build/ruby(rbimpl_RB_TYPE_P_fastpath) ../src/include/ruby/internal/value_type.h:351
  /Users/runner/work/ruby/ruby/build/ruby(RB_FL_ABLE) ../src/include/ruby/internal/fl_type.h:449
  /Users/runner/work/ruby/ruby/build/ruby(RB_FL_UNSET_RAW) ../src/include/ruby/internal/fl_type.h:668
  /Users/runner/work/ruby/ruby/build/ruby(RB_ENC_CODERANGE_SET) ../src/include/ruby/internal/encoding/coderange.h:131
  /Users/runner/work/ruby/ruby/build/ruby(rb_str_buf_append) ../src/string.c:3429
  /Users/runner/work/ruby/ruby/build/ruby(rb_str_concat_literals+0x214) [0x10501358c] ../src/string.c:3459

https://github.com/ruby/ruby/actions/runs/7981888849/job/21794443595

@matzbot matzbot requested a review from a team February 21, 2024 00:38
@k0kubun
Copy link
Member Author

k0kubun commented Feb 21, 2024

This happens too often. The team seems offline, so let me merge this for now and get feedback afterwards.

@k0kubun k0kubun merged commit ce4142b into ruby:master Feb 21, 2024
@k0kubun k0kubun deleted the yjit-concatstrings branch February 21, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@k0kubun