YJIT: Specialize String#[] (String#slice) with fixnum arguments
#12069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8bad4f to
0ad866a
Compare
maximecb
reviewed
Nov 12, 2024
0ad866a to
15096d4
Compare
k0kubun
reviewed
Nov 12, 2024
k0kubun
reviewed
Nov 12, 2024
k0kubun
approved these changes
Nov 12, 2024
289a87b to
9d0d3d4
Compare
String#[] is in the top few C calls of several YJIT benchmarks: liquid-compile rubocop mail sudoku This speeds up these benchmarks by 1-2%.
In the large generated code of the mail gem the context doesn't have the type info. In that case if we peek at the stack and add a guard we can still apply the specialization and it speeds up the mail benchmark by 5%. Co-authored-by: Maxime Chevalier-Boisvert <[email protected]> Co-authored-by: Takashi Kokubun (k0kubun) <[email protected]>
9d0d3d4 to
df4fe2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String#[]is in the top few C calls of several YJIT benchmarks:liquid-compile rubocop mail sudoku
While it has 5 different argument scenarios the most common by far are one fixnum and two fixnums
so we match those argument types and write the ccall directly to the corresponding C function.
This speeds up these benchmarks by 1-5%.
This is similar to the
String#byteslicespecialization #9939but it works harder to find the type info which was necessary for the specialization to apply in the large generated code of the
mailgem.