Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Lock json-schema-5.1.0 for Ruby 3.3 #12234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2024
Merged

Lock json-schema-5.1.0 for Ruby 3.3 #12234

merged 2 commits into from
Dec 3, 2024

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Dec 3, 2024 •
edited
Loading

Fixed https://github.com/ruby/actions/actions/runs/12125808886/job/33806775870

  Building native extensions. This could take a while...
  ERROR:  Error installing json-schema:
  	ERROR: Failed to build gem native extension.
  
      current directory: /home/runner/work/actions/actions/snapshot-ruby_3_3/.bundle/gems/bigdecimal-3.1.8/ext/bigdecimal
  /usr/local/bin/ruby -I/home/runner/work/actions/actions/snapshot-ruby_3_3/lib extconf.rb
  extconf failedNo such file or directory - /usr/local/bin/ruby

We can't use C extension with make test-bundled-gems.

@hsbt hsbt requested a review from k0kubun as a code owner December 3, 2024 01:01
This was referenced Dec 3, 2024
Merged
Merged
@hsbt
Copy link
Member Author

hsbt commented Dec 3, 2024

https://github.com/ruby/ruby/actions/runs/12130888293/job/33822064923?pr=12234#step:4:56

  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --filter=blob:none --depth=1 origin +3645e0653e3196e89a4e83cb4631666b12ef9b46:refs/remotes/pull/12234/merge
  Error: fatal: --filter can only be used when extensions.partialClone is set
  The process '/usr/bin/git' failed with exit code 128

sparse-checkout is not working with old Git. The old compiler images used the following version.

git version 2.25.1

We can ignore that with actions/checkout#1656. I also update actions/[email protected] in this PR.

@hsbt hsbt merged commit 732ee20 into ruby:ruby_3_3 Dec 3, 2024
95 checks passed
@hsbt hsbt deleted the fix-test-bundled-gems-3-3 branch December 3, 2024 02:08
@hsbt hsbt added the Backport label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0kubun k0kubun k0kubun approved these changes

Assignees
No one assigned
Labels
Backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsbt @k0kubun