[DOC] Move Time#xmlschema docs to the core #12403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
approved these changes
Dec 19, 2024
jeremyevans
approved these changes
Dec 19, 2024
5c6696d to
3bffb07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
Time#xmlschemawas moved totime.cin Feature #20707, its docs still suggestrequire 'time'in text and code examples.This PR does NOT solve the issue fully: while
Time#xmlschemais still in time.rb (guarded byunless method_defined?(:xmlschema)), RDoc prefers that version of the docs.I don’t know how to solve that right now (maybe there is some RDoc setting to prefer the “proper” version?). But I believe it makes sense to at least have a copy of the docs in the
time.canyway.PS: But actually, maybe it makes sense to remove the method from
time.rb(and release the change in the gem version, which requiresruby >= 3.4.0)?..